From abfbc59837f021a9d3320e6ea27d47b5560d5944 Mon Sep 17 00:00:00 2001 From: Zach Smith Date: Tue, 28 Apr 2026 09:38:24 -0700 Subject: [PATCH] fix: wire BUILD_IROH_SERVICES_API_KEY into bundle and release workflows The diagnostics module reads BUILD_IROH_SERVICES_API_KEY via option_env!() at compile time as a fallback when the runtime IROH_SERVICES_API_KEY isn't set, but neither workflow exported the secret to the build env, so released apps shipped without a key baked in and logged "Net diagnostics disabled: IROH_SERVICES_API_KEY not set" on launch. Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/bundle.yml | 1 + .github/workflows/manual-release.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/bundle.yml b/.github/workflows/bundle.yml index 16b5e94..5ee4924 100644 --- a/.github/workflows/bundle.yml +++ b/.github/workflows/bundle.yml @@ -32,6 +32,7 @@ jobs: env: BUILD_N0DES_API_SECRET: ${{ secrets.N0DES_API_SECRET }} + BUILD_IROH_SERVICES_API_KEY: ${{ secrets.BUILD_IROH_SERVICES_API_KEY }} BUILD_DATUM_CONNECT_RELAY_URLS: ${{ vars.BUILD_DATUM_CONNECT_RELAY_URLS }} BUILD_DATUM_CONNECT_CREATE_TRAFFIC_PROTECTION_POLICIES: ${{ vars.BUILD_DATUM_CONNECT_CREATE_TRAFFIC_PROTECTION_POLICIES }} DATUM_API_ENV: production diff --git a/.github/workflows/manual-release.yml b/.github/workflows/manual-release.yml index 4041e12..513222a 100644 --- a/.github/workflows/manual-release.yml +++ b/.github/workflows/manual-release.yml @@ -25,6 +25,7 @@ jobs: env: BUILD_N0DES_API_SECRET: ${{ secrets.N0DES_API_SECRET }} + BUILD_IROH_SERVICES_API_KEY: ${{ secrets.BUILD_IROH_SERVICES_API_KEY }} BUILD_DATUM_CONNECT_RELAY_URLS: ${{ vars.BUILD_DATUM_CONNECT_RELAY_URLS }} BUILD_DATUM_CONNECT_CREATE_TRAFFIC_PROTECTION_POLICIES: ${{ vars.BUILD_DATUM_CONNECT_CREATE_TRAFFIC_PROTECTION_POLICIES }} DATUM_API_ENV: production