feat: normalize 'to' field to https:// when no scheme provided

[igoramf]

Summary by cubic

Normalize the redirect "to" field by trimming whitespace and defaulting to https:// when no scheme is provided. This ensures stored redirects are valid and consistent.

• New Features
  • Trim to and prepend https:// if no scheme is present in the create handler.
  • Added a test to verify the normalized value is saved as https://....

^{Written for commit 3321246. Summary will update on new commits. Review in cubic}

[cubic-dev-ai]

2 issues found across 2 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="internal/api/handlers.go">

<violation number="1" location="internal/api/handlers.go:77">
P1: The scheme prefix check is case-sensitive, so uppercase schemes like 'HTTP://' or 'HTTPS://' are not recognized and get a duplicate 'https://' prepended, producing a malformed URL.</violation>
</file>

<file name="internal/api/server_test.go">

<violation number="1" location="internal/api/server_test.go:80">
P2: Missing guard against empty Items slice before accessing Items[0]. If the create handler returns 201 without persisting the object, list.Items will be empty and this line will panic with an index-out-of-range error.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

P1: The scheme prefix check is case-sensitive, so uppercase schemes like 'HTTP://' or 'HTTPS://' are not recognized and get a duplicate 'https://' prepended, producing a malformed URL.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At internal/api/handlers.go, line 77:

<comment>The scheme prefix check is case-sensitive, so uppercase schemes like 'HTTP://' or 'HTTPS://' are not recognized and get a duplicate 'https://' prepended, producing a malformed URL.</comment>

<file context>
@@ -69,10 +69,14 @@ func (h *Handlers) create(w http.ResponseWriter, r *http.Request) {
 		http.Error(w, "'to' is required", http.StatusBadRequest)
 		return
 	}
+	if !strings.HasPrefix(to, "http://") && !strings.HasPrefix(to, "https://") {
+		to = "https://" + to
+	}
</file context>

Suggested change

	if !strings.HasPrefix(to, "http://") && !strings.HasPrefix(to, "https://") {
	if !strings.HasPrefix(strings.ToLower(to), "http://") && !strings.HasPrefix(strings.ToLower(to), "https://") {

[cubic-dev-ai]

P2: Missing guard against empty Items slice before accessing Items[0]. If the create handler returns 201 without persisting the object, list.Items will be empty and this line will panic with an index-out-of-range error.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At internal/api/server_test.go, line 80:

<comment>Missing guard against empty Items slice before accessing Items[0]. If the create handler returns 201 without persisting the object, list.Items will be empty and this line will panic with an index-out-of-range error.</comment>

<file context>
@@ -58,6 +58,30 @@ func TestCreate_HappyPath(t *testing.T) {
+
+	list := &decositesv1alpha1.DecoRedirectList{}
+	_ = fc.List(context.Background(), list)
+	if list.Items[0].Spec.To != "https://www.example.com" {
+		t.Fatalf("expected to=https://www.example.com, got %s", list.Items[0].Spec.To)
+	}
</file context>

Suggested change

	if list.Items[0].Spec.To != "https://www.example.com" {
	if len(list.Items) != 1 {
	t.Fatalf("expected 1 DecoRedirect, got %d", len(list.Items))
	}
	if list.Items[0].Spec.To != "https://www.example.com" {