Skip to content

Commit 1dd3d32

Browse files
Merge origin/main and reject incomplete triage summaries
Carry forward the merged safe-output preparation guidance and reject embedded template placeholders in triage rows and prose sections. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2 parents fd3482c + a846e2a commit 1dd3d32

43 files changed

Lines changed: 2614 additions & 215 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.github/ISSUE_TEMPLATE/bug-report.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
name: Bug report
33
about: Create a report to help us improve
44
title: ""
5-
labels: [":new: Triage Needed", ":bug: Bug!"]
5+
type: Bug
66
assignees: []
77

88
---

‎.github/ISSUE_TEMPLATE/feature_request.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
name: Feature request
33
about: Suggest an idea for this project
44
title: ""
5-
labels: [":new: Triage Needed", ":bulb: Enhancement"]
5+
type: Feature
66
assignees: []
77

88
---

‎.github/scripts/tests/validate-triage-output.test.cjs‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,28 @@ test('requires every check row and non-placeholder values', () => {
7676
}
7777
});
7878

79+
test('rejects embedded template placeholders in rows and prose sections', () => {
80+
const unfinished = [
81+
[summary.replace('Missing: SQL Server version', 'Missing: <list>'), /check row/],
82+
[summary.replace(
83+
'Cancellation leaves the operation running. Investigate the async cancellation path; P1.',
84+
'Cancellation leaves the operation running. Investigate <the affected component>; P1.'
85+
), /Analysis/],
86+
[summary.replace(
87+
'- Ask the author for their SQL Server version.',
88+
'- Ask the author for their <missing details>.'
89+
), /Next Steps/],
90+
];
91+
for (const [body, message] of unfinished) {
92+
assert.throws(() => validateTriageOutput(output(body)), message);
93+
}
94+
95+
validateTriageOutput(output(summary.replace(
96+
'Cancellation leaves the operation running.',
97+
'Cancellation leaves the operation running; SqlDataReader.GetFieldValue<T>() is affected.'
98+
)));
99+
});
100+
79101
test('requires populated Analysis and Next Steps sections', () => {
80102
assert.throws(() => validateTriageOutput(output(summary.replace(
81103
'Cancellation leaves the operation running. Investigate the async cancellation path; P1.', ''

‎.github/scripts/validate-triage-output.cjs‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44

55
const fs = require('node:fs');
66

7+
const TEMPLATE_PLACEHOLDER_PATTERN =
8+
/<\s*(?:list|fields?|values?|authors?|types?|versions?|areas?|results?|details?|descriptions?|summaries?|items?|labels?|[^>\r\n]*\s[^>\r\n]*|[^>\r\n]*[|\/][^>\r\n]*)\s*>/i;
9+
710
function proseOnly(body) {
811
let fence;
912
return body.replace(/<!--[\s\S]*?(?:-->|$)/g, '').split('\n').map(line => {
@@ -26,7 +29,7 @@ function proseOnly(body) {
2629
function meaningful(value) {
2730
const text = value.replace(/[*_`]/g, '').trim();
2831
return /[\p{L}\p{N}]/u.test(text) &&
29-
!/^<[\s\S]*>$/.test(text) &&
32+
!TEMPLATE_PLACEHOLDER_PATTERN.test(text) &&
3033
!/^(?:todo|tbd|test(?: message)?(?: please ignore)?|placeholder)$/i.test(text);
3134
}
3235

‎.github/workflows/issue-triage.lock.yml‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎.github/workflows/issue-triage.md‎

Lines changed: 18 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -140,45 +140,24 @@ Do NOT post intermediate findings. Do NOT post separate comments for
140140
area detection, duplicate checking, or environment validation.
141141
Everything goes into the single triage summary at the end.
142142

143-
## Safe-output submission
144-
145-
Every successful `safeoutputs` call queues a real write; it is NOT a dry run.
146-
Never test a write tool with a placeholder, `test` message, `-`, or `@-`.
147-
Do not experiment with alternative comment calls after a submission error.
148-
149-
Finish all analysis and compose the complete Markdown summary in
150-
`/tmp/gh-aw/agent/triage-summary.md` using the file-writing tool. Before any
151-
write intent, check that it starts with the Triage Summary heading, has all
152-
five populated check rows, and contains meaningful Analysis and Next Steps
153-
sections. Replace every template placeholder; do not wrap the summary in a
154-
code fence or quote.
155-
156-
Use the allowed `jq` command to JSON-encode the entire file without shell
157-
interpolation of its contents:
158-
159-
```bash
160-
jq -Rs '{body: .}' /tmp/gh-aw/agent/triage-summary.md > /tmp/gh-aw/agent/triage-summary.json
161-
jq -e 'type == "object" and (.body | type == "string" and length > 0)' /tmp/gh-aw/agent/triage-summary.json
162-
```
163-
164-
Run these local preparation/check commands first and confirm both succeed.
165-
Only then submit the finished payload exactly once:
166-
167-
```bash
168-
safeoutputs add_comment . < /tmp/gh-aw/agent/triage-summary.json
169-
```
170-
171-
The standalone `.` reads a JSON object from stdin. `-` and `@-` are NOT
172-
stdin sentinels. Do not use `--body -`, `--body @-`, hand-escaped Markdown
173-
in shell arguments, or raw GitHub writes. The comment target defaults to
174-
the triggering issue; do not override the target.
175-
176-
If preparation or submission fails, stop without changing labels. Report
177-
the failure through `safeoutputs report_incomplete` with the actual error;
178-
do not call `add_comment` again, send a substitute comment, or claim success.
179-
Only queue the permitted label action after the final comment is accepted.
180-
The safe-output job validates the result before any comments or labels are
181-
published and rejects placeholders or mixed success/incomplete outcomes.
143+
### Safe-output preparation
144+
145+
Every successful safe-output call queues a real action and consumes its
146+
per-run allowance. Never call `add_comment` with test, placeholder, diagnostic,
147+
or partial content, even to check whether the tool works.
148+
149+
Finish the analysis and prepare the complete summary before calling
150+
`add_comment`. When using the `safeoutputs` CLI, inspect
151+
`safeoutputs add_comment --help` to confirm its arguments without consuming
152+
the allowance. The target argument is `item_number`, not `issue_number`.
153+
For a multi-line summary saved to a temporary file, use the allowed `jq -Rs`
154+
command to construct the JSON payload with `item_number` and `body`, then
155+
submit it once through `safeoutputs add_comment .`.
156+
157+
If preparation or submission fails, inspect the error before retrying.
158+
Do not repeatedly retry a denied command or probe with a write. If the
159+
failure cannot be resolved with the available tools, call `report_incomplete`
160+
with the actual error and stop without submitting placeholder content.
182161

183162
---
184163

‎BUILDGUIDE.md‎

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -282,6 +282,37 @@ Package Microsoft.Data.SqlClient.Extensions.Azure without building it beforehand
282282
dotnet build -t:PackAzure -p:PackBuild=false
283283
```
284284

285+
### Release Source Link Symbols
286+
287+
To reproduce release symbol generation locally, set `BuildForRelease` in the environment before
288+
packing. `build.proj` launches child `dotnet` processes, so passing only
289+
`-p:BuildForRelease=true` to the orchestrator does not enable it in those processes.
290+
291+
```powershell
292+
$env:BuildForRelease = 'true'
293+
dotnet build build.proj -t:PackSqlClient -p:Configuration=Release
294+
Remove-Item Env:\BuildForRelease
295+
```
296+
297+
The `.nupkg` and matching `.snupkg` are written to
298+
`artifacts/Microsoft.Data.SqlClient/Project-Release/`. Inspect them together with
299+
[PackageValidator](tools/PackageValidator/README.md) or NuGet Package Explorer.
300+
301+
To fail validation on missing source coverage or non-portable source paths:
302+
303+
```powershell
304+
dotnet run --project tools\PackageValidator\src\PackageValidator.csproj -- `
305+
artifacts\Microsoft.Data.SqlClient\Project-Release `
306+
--fail-on missing-source-link --fail-on untracked-source --fail-on non-deterministic-source-path
307+
```
308+
309+
Tracked source paths in the PDBs must match the Source Link document map; generated sources must
310+
be embedded. Keep the repository root configured in `RepositoryInfo.targets` as the source root:
311+
adding a separate `src/` root without source-control metadata can remap tracked files to `/_1/`
312+
while Source Link only maps `/_/`. NuGet Package Explorer reports this as
313+
**Contains untracked sources (obj)** for both Source Link and Deterministic, even when all `obj`
314+
sources are embedded and the compiler's deterministic flag is enabled.
315+
285316
## Versioning
286317

287318
Versioning can be accomplished by using a mix of different parameters to the `build.proj` targets:

‎CHANGELOG.md‎

Lines changed: 49 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,56 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
66

77
> **Note:** Releases are sorted in reverse chronological order (newest first).
88
9+
## [Stable Release 7.1.0] - 2026-09-17
10+
11+
General availability of Microsoft.Data.SqlClient 7.1. The sections below list the changes since [7.1.0-preview3](release-notes/7.1/7.1.0-preview3.md). See the [7.1.0 release notes](release-notes/7.1/7.1.0.md) for the cumulative list of changes since the 7.0.3 stable release.
12+
13+
### Added
14+
15+
- Added a `RegisteredApplication` enum and a matching `SqlConnection.RegisteredApplication` property that let a library or tool identify itself to SQL Server through version 2 of the TDS USERAGENT feature extension. The payload also carries a new driver-owned 64-bit *Driver Properties* flag field; bit 0 reports whether connection pool V2 is enabled for the process. Application identity is client-supplied telemetry and must never be used for authorization or any other security decision. The value must be set before `Open`/`OpenAsync` and is not part of the connection pool key.
16+
([#3201](https://github.com/dotnet/SqlClient/issues/3201), [#4632](https://github.com/dotnet/SqlClient/pull/4632))
17+
18+
### Changed
19+
20+
- `SqlConnectionStringBuilder.TransparentNetworkIPResolution` is now marked `[Obsolete]`, directing callers to `MultiSubnetFailover`. There is no runtime behavior change: connection string defaults are untouched and no new AppContext switches were introduced. The only visible effect is a `CS0618` build warning for code that references the property.
21+
([#4494](https://github.com/dotnet/SqlClient/issues/4494), [#4576](https://github.com/dotnet/SqlClient/pull/4576))
22+
23+
- Unified the exception message raised when conflicting token-based and SSPI authentication properties are set on the same `SqlConnection`, and documented the complete set of properties that conflict with `AccessToken`.
24+
([#4629](https://github.com/dotnet/SqlClient/pull/4629))
25+
26+
- Documentation corrections for `SqlDataRecord`, `SqlMetaData`, and the LCID 1033 locale name.
27+
([#1805](https://github.com/dotnet/SqlClient/issues/1805),
28+
[#4440](https://github.com/dotnet/SqlClient/pull/4440),
29+
[#4646](https://github.com/dotnet/SqlClient/pull/4646))
30+
31+
- Updated `Microsoft.Data.SqlClient.SNI` and `Microsoft.Data.SqlClient.SNI.runtime` to v7.1.0 (was v7.1.0-preview3.26226.3).
32+
([#4698](https://github.com/dotnet/SqlClient/pull/4698))
33+
34+
### Fixed
35+
36+
- Fixed a pooled connection being returned to the pool in a broken state after a `TransactionScope` rollback — for example, when distributed transaction promotion fails on .NET 8+ where implicit distributed transactions are disabled by default. Connection reset now preserves the transaction when the pooled connection is either a delegated transaction root or enlisted in a transaction.
37+
([#4001](https://github.com/dotnet/SqlClient/issues/4001), [#4557](https://github.com/dotnet/SqlClient/pull/4557))
38+
39+
- Fixed `GetSchema("DataTypes")` never reporting the SQL Server 2025 `json` type against Azure SQL. The decision now uses the `json` support flag negotiated through the TDS `FEATUREEXTACK` token instead of a server version string comparison.
40+
([#4592](https://github.com/dotnet/SqlClient/issues/4592), [#4682](https://github.com/dotnet/SqlClient/pull/4682))
41+
42+
- Fixed a malformed UNC pipe path being composed for IPv6 literal server names over Named Pipes in managed SNI, which could trigger an access violation inside LSASS on Windows and force a reboot. IPv6 literals are now transcribed to their `.ipv6-literal.net` form. (net8.0/net9.0 only)
43+
([#4523](https://github.com/dotnet/SqlClient/issues/4523), [#4558](https://github.com/dotnet/SqlClient/pull/4558))
44+
45+
- Fixed configurable retry logic installing a permanent, process-wide assembly-resolution handler that could interfere with unrelated assembly loading. The handler is now installed only while an explicitly configured custom retry provider is resolved and constructed, and probes `AppContext.BaseDirectory` instead of the current working directory. (net8.0/net9.0 only)
46+
([#2214](https://github.com/dotnet/SqlClient/issues/2214), [#4547](https://github.com/dotnet/SqlClient/pull/4547))
47+
48+
- Fixed open/close throughput regressions in the opt-in connection pool V2 (`Switch.Microsoft.Data.SqlClient.UseConnectionPoolV2`). The default pool is unaffected.
49+
([#4543](https://github.com/dotnet/SqlClient/pull/4543))
50+
51+
### Companion packages
52+
53+
- Released `Microsoft.Data.SqlClient.Extensions.Azure` 7.1.0 with an internal Entra ID authority parsing clarification and no behavior change. See [release notes](release-notes/Extensions/Azure/7.1/7.1.0.md).
54+
- Released version-aligned `Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider`, `Microsoft.Data.SqlClient.Extensions.Abstractions`, and `Microsoft.Data.SqlClient.Internal.Logging` 7.1.0 with no functional or API changes since preview3. See the [Azure Key Vault provider](release-notes/add-ons/AzureKeyVaultProvider/7.1/7.1.0.md), [Abstractions](release-notes/Extensions/Abstractions/7.1/7.1.0.md), and [Logging](release-notes/Internal/Logging/7.1/7.1.0.md) release notes.
55+
956
## [Stable Release 7.0.3] - 2026-09-10
1057

58+
1159
### Changed
1260

1361
- Updated the `Microsoft.Data.SqlClient.SNI` and `Microsoft.Data.SqlClient.SNI.runtime` dependencies to 6.0.3 (was 6.0.2).
@@ -227,7 +275,7 @@ See the [full release notes](release-notes/7.1/7.1.0-preview2.md) for detailed d
227275
- `SqlVector<float>` now serializes and deserializes multibyte values as little-endian explicitly.
228276
([#3861](https://github.com/dotnet/SqlClient/pull/3861))
229277

230-
- Updated the bundled .NET 10 SDK to `10.0.300`.
278+
- Updated the .NET 10 SDK used to build the repository to `10.0.300`.
231279
([#4287](https://github.com/dotnet/SqlClient/pull/4287))
232280

233281
- Re-shipped `Microsoft.Data.SqlClient.Extensions.Azure` as `7.1.0-preview2`, adding Windows Account Manager (WAM) broker support for Entra ID authentication on Windows. See [release notes](release-notes/Extensions/Azure/7.1/7.1.0-preview2.md).

‎Directory.Packages.props‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
-->
5353
<PropertyGroup>
5454
<!-- SNI version (external package, version declared once here) -->
55-
<SniVersion>7.1.0-preview3.26226.3</SniVersion>
55+
<SniVersion>7.1.0</SniVersion>
5656
<SniVersionRange>[$(SniVersion), $([MSBuild]::Add($(SniVersion.Split('.')[0]), 1)).0.0)</SniVersionRange>
5757
</PropertyGroup>
5858

‎doc/snippets/Microsoft.Data.SqlClient/SqlConnection.xml‎

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -361,9 +361,14 @@ The following example creates a <xref:Microsoft.Data.SqlClient.SqlCommand> and a
361361
are the same, they will be grouped into the same connection pool.
362362
</para>
363363
<para>
364-
When using a token callback function, the connection manages
365-
refreshing the tokens returned by the callback. The application is
366-
not responsible for knowing when tokens expire.
364+
The driver manages token refresh and discards pooled connections with
365+
expired or nearly expired tokens before reuse. Connections in use or
366+
reused within the same active transaction are unaffected.
367+
</para>
368+
<para>
369+
New physical connections invoke the callback only when a cached token
370+
is missing or needs refreshing. Reusing a pooled connection does not
371+
invoke the callback.
367372
</para>
368373
<para>
369374
This property is mutually exclusive with the

0 commit comments

Comments
 (0)