Skip to content

Fix race condition in AssetCachingTests and re-enable test #123167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 5 commits into from
+13 −6
Closed

Fix race condition in AssetCachingTests and re-enable test #123167

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ab21220
Initial plan
Copilot Jan 14, 2026
d036970
Fix race condition in AssetCachingTests by using separate TaskComplet…
Copilot Jan 14, 2026
54bb1d8
Use counter to properly track which page load to signal
Copilot Jan 14, 2026
01819d3
Add explicit count check to handle only first two page loads
Copilot Jan 14, 2026
900b9fc
Remove ActiveIssue attribute now that race condition is fixed
Copilot Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions src/mono/wasm/Wasm.Build.Tests/Blazor/AssetCachingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using System.Collections.Generic;
using System.IO;
using System.Text.RegularExpressions;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.Playwright;
using Xunit;
Expand All @@ -22,7 +23,6 @@ public AssetCachingTests(ITestOutputHelper output, SharedBuildPerTestClassFixtur
}

[Fact, TestCategory("no-fingerprinting")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/122338")] // add it back to eng\testing\scenarios\BuildWasmAppsJobsList.txt
public async Task BlazorApp_BasedOnFingerprinting_LoadsWasmAssetsFromCache()
{
var project = CopyTestAsset(
Expand All @@ -35,7 +35,9 @@ public async Task BlazorApp_BasedOnFingerprinting_LoadsWasmAssetsFromCache()

(string projectDir, string output) = BlazorPublish(project, Configuration.Release, new PublishOptions(AssertAppBundle: false));

var counterLoaded = new TaskCompletionSource();
var firstCounterLoaded = new TaskCompletionSource();
var secondCounterLoaded = new TaskCompletionSource();
var loadCount = 0;
var wasmRequestRecorder = new WasmRequestRecorder();

var runOptions = new BlazorRunOptions(Configuration.Release)
Expand All @@ -45,23 +47,28 @@ public async Task BlazorApp_BasedOnFingerprinting_LoadsWasmAssetsFromCache()
OnConsoleMessage = (type, msg) =>
{
if (msg.Contains("Counter.OnAfterRender"))
counterLoaded.SetResult();
{
var count = Interlocked.Increment(ref loadCount);
if (count == 1)
firstCounterLoaded.SetResult();
else if (count == 2)
secondCounterLoaded.SetResult();
}
},
Test = async (page) =>
{
await counterLoaded.Task;
await firstCounterLoaded.Task;

// Check server request logs after the first load.
Assert.NotEmpty(wasmRequestRecorder.ResponseCodes);
Assert.All(wasmRequestRecorder.ResponseCodes, r => Assert.Equal(200, r.ResponseCode));

wasmRequestRecorder.ResponseCodes.Clear();
counterLoaded = new();

// Perform browser navigation to cause resource reload.
// We use the initial base URL because the test server is not configured for SPA routing.
await page.ReloadAsync();
await counterLoaded.Task;
await secondCounterLoaded.Task;

// Check server logs after the second load.
if (EnvironmentVariables.UseFingerprinting)
Expand Down
Loading