Repository navigation
Remove windows .bat and .ps1 launchers - #27359
Conversation
ac8d7b2 to
a1febca
Compare
|
@juj, I will wait for you to confirm that the new binary launcher is working for you before I land this. |
|
Yeah, let's go ahead. I haven't had a chance to test this extensively, but happy to validate this afterwards. The only concern I had was the antivirus detection, but at Unity we are setting up a code signing deployment, so those executables will be shipped as signed, so that should avoid issues there. |
juj
left a comment
juj
left a comment
There was a problem hiding this comment.
There is a bunch of breaking changes in terms of having to rename 'emcc.bat' -> 'emcc.exe' and so on in any build system code that drives Emscripten (on Windows, just invoking 'emcc' requires shell expansion to autocomplete the suffix, so typically avoided where possible)
But I don't think these types of changes come often, so it'll be a one time breakage to address.
a1febca to
f4bece7
Compare
We have been using the `.exe` launchers (see emscripten-core#27017) for a few releases now with no issues. See: emscripten-core#24858
f4bece7 to
bfae897
Compare
sbc100
changed the title
.bat and .ps1 launchers
3 participants
We have been using the
.exelaunchers (see #27017) for a few releasesnow with no issues.
See: #24858