Repository navigation
Commit 446434e
committed
Fix iOS + Linux/Windows bridge_example CI failures
Three issues from the previous CI run:
1. test_wheel_build (throwaway) didn't upload wheel artifacts — only
built them and listed filenames. Bridge example Linux/Windows then
failed downloading the missing artifacts. Added actions/upload-
artifact step that mirrors ci.yml's release_build.
2. iOS bridge_example failed: serious_python_darwin's
sync_site_packages.sh only populates dist_ios/site-xcframeworks
when iOS-specific site-packages subdirs (iphoneos.arm64,
iphonesimulator.arm64, iphonesimulator.x86_64) exist. Empty
--requirements falls to the macOS branch which doesn't create
that directory, and bundle-python-frameworks-ios.sh later fails
`find dist_ios/site-xcframeworks` with `No such file or directory`.
Workaround: pass `--requirements certifi` (a tiny pure-Python
placeholder, the same shape as flet_example's flet==0.28.3) to
trigger the iOS site-xcframeworks population.
3. test-bridge-build.yml had no workflow-level
SERIOUS_PYTHON_SITE_PACKAGES env var. ci.yml sets this at the top
(line 15) so all jobs inherit. The throwaway needs the same so
sync_site_packages.sh knows where package_command.dart staged the
bundled site-packages.
The certifi workaround is fragile; a cleaner long-term fix is to
patch sync_site_packages.sh to always create site-xcframeworks (with
just the base python xcframeworks, no user deps required). Adding to
bridge-followups.1 parent 08bbadc commit 446434e
2 files changed
Lines changed: 26 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
298 | 298 | | |
299 | 299 | | |
300 | 300 | | |
301 | | - | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
302 | 308 | | |
303 | 309 | | |
304 | 310 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
14 | 20 | | |
15 | 21 | | |
16 | 22 | | |
| |||
35 | 41 | | |
36 | 42 | | |
37 | 43 | | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
44 | 51 | | |
45 | 52 | | |
46 | 53 | | |
| |||
169 | 176 | | |
170 | 177 | | |
171 | 178 | | |
172 | | - | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
173 | 185 | | |
174 | 186 | | |
175 | 187 | | |
| |||
0 commit comments