Skip to content

Commit 7ebe615

Browse files
committed
Pin Node and don't rely on --test scanning a directory
node --test only searches a directory given as a positional from v25, so CI's Node 24 tried to load test/assets as a module. Pass the files instead, which works on any version. Pin the version in .tool-versions alongside Ruby, so CI and a local checkout agree on one place.
1 parent bccc07a commit 7ebe615

3 files changed

Lines changed: 3 additions & 2 deletions

File tree

‎.github/workflows/test.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
- name: Set up Node
2727
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
2828
with:
29-
node-version: lts/*
29+
node-version-file: .tool-versions
3030
cache: npm
3131
- run: npm ci
3232
- name: Typecheck the assets

‎.tool-versions‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
ruby 4.0.6
2+
nodejs 26.8.2

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "devdocs",
33
"private": true,
44
"scripts": {
5-
"test": "node --test test/assets/",
5+
"test": "node --test test/assets/*_test.js",
66
"typecheck": "tsc -p tsconfig.json && tsc -p test/assets/tsconfig.json"
77
},
88
"devDependencies": {

0 commit comments

Comments
 (0)