ref(flags): Remove organizations:ds-health-checks-trace-based#115013
Closed
wedamija wants to merge 3 commits into
Closed
ref(flags): Remove organizations:ds-health-checks-trace-based#115013wedamija wants to merge 3 commits into
wedamija wants to merge 3 commits into
Conversation
Scanner classified this as ga-ready-to-graduate: 100% rolled out with no conditions. Removes the gate in get_relay_biases — trace-based health checks are now unconditional. The transaction-based bias is no longer added; that import goes away from combine.py (the class still exists for other consumers / dynamic_sampling exports). @getsentry/telemetry-experience Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
After removing organizations:ds-health-checks-trace-based, the IGNORE_HEALTH_CHECKS_RULE always uses the trace-based bias (IGNORE_HEALTH_CHECKS_FACTOR_TRACES = 3) instead of the legacy transaction-based bias (FACTOR_TRANSACTIONS = 5). Update assertions: type=transaction → trace, name=event.transaction → trace.transaction, divisor 5 → 3. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jjbayer
reviewed
May 7, 2026
Member
jjbayer
left a comment
jjbayer
left a comment
There was a problem hiding this comment.
LGTM but will let @shellmayr have final say.
With the flag removal always using IgnoreHealthChecksTraceBias, the transaction-based variant has no callers. Remove the class, its test, its constant (IGNORE_HEALTH_CHECKS_FACTOR_TRANSACTIONS), and its re-export from dynamic_sampling/__init__.py. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
|
Seems related to #115471 |
Member
|
Closing this one as duplicate of https://github.com/getsentry/sentry/pull/115471/changes - made some changes to tests so we keep coverage that weren't in this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scanner classified this as ga-ready-to-graduate: 100% rolled out with no conditions. Removes the gate in get_relay_biases — trace-based health checks are now unconditional. The transaction-based bias is no longer added; that import goes away from combine.py (the class still exists for other consumers / dynamic_sampling exports).