Merge pull request #671 from immutable/chore/clean-up

chore: clean up

Author: nattb8

src/Packages/Passport/Documentation~/DOCUMENTATION.md

@@ -1,4 +1,3 @@
 # Documentation
 
-* [Immutable X](https://docs.immutable.com/docs/x/sdks/unity)
-* [Immutable zkEVM](https://docs.immutable.com/docs/zkEVM/sdks/unity)
+[Immutable](https://docs.immutable.com/docs/immutable)

src/Packages/Passport/Private.meta

@@ -11,7 +11,7 @@ namespace Immutable.Passport.Event
     public class PassportAnalytics
     {
         public const string TRACK = "track";
-        public const string MODULE_NAME = "unitySdk";
+        private const string MODULE_NAME = "unitySdk";
 
         public static class EventName
         {
@@ -26,7 +26,7 @@ public static class EventName
             public const string COMPLETE_LOGOUT_PKCE = "performedLogoutPkce";
         }
 
-        public static class Properties
+        private static class Properties
         {
             public const string SUCCESS = "succeeded";
         }
@@ -36,15 +36,12 @@ public async UniTask Track(IBrowserCommunicationsManager communicationsManager,
         {
             try
             {
-                if (properties == null)
-                {
-                    properties = new Dictionary<string, object>();
-                }
+                properties ??= new Dictionary<string, object>();
                 if (success != null)
                 {
                     properties.Add(Properties.SUCCESS, success);
                 }
-                string json = JsonUtility.ToJson(new TrackData()
+                var json = JsonUtility.ToJson(new TrackData
                 {
                     moduleName = MODULE_NAME,
                     eventName = eventName,

src/Packages/Passport/Private/Helpers.meta

@@ -25,24 +25,6 @@ public static class JsonExtensions
             }
         }
 
-        public static string ToJson<T>(this T[] array)
-        {
-            // Need a wrapper to serialise arrays
-            var wrapper = new Wrapper<T> { Items = array };
-            var wrapped = JsonUtility.ToJson(wrapper);
-
-            // Remove the wrapper
-            return wrapped.ReplaceFirst("{\"Items\":", "").TrimEnd('}');
-        }
-
-        private static string ReplaceFirst(this string source, string search, string replace)
-        {
-            var pos = source.IndexOf(search);
-            return pos < 0
-                ? source
-                : source.Substring(0, pos) + replace + source.Substring(pos + search.Length);
-        }
-
         public static string ToJson(this IDictionary<string, object> dictionary)
         {
             // JsonUtility cannot serialise dictionary, but not using newtonsoft json as it doesn't

src/Packages/Passport/Runtime/Scripts/Private/Event/AnalyticsEvent.cs

@@ -12,11 +12,11 @@ public static class UriExtensions
         {
             try
             {
-                string query = uri.Query;
-                string[] queryParameters = query.Split(new char[] { '?', '&' });
-                for (int i = 0; i < queryParameters.Length; i++)
+                var query = uri.Query;
+                var queryParameters = query.Split(new char[] { '?', '&' });
+                foreach (var queryParameter in queryParameters)
                 {
-                    string[] keyValue = queryParameters[i].Split('=');
+                    string[] keyValue = queryParameter.Split('=');
                     if (keyValue[0] == key)
                     {
                         return keyValue[1];