Skip to content

Commit b1f230c

Browse files
committed
Fix pan knobs not being displayed when building without reverb
1 parent 2eda63b commit b1f230c

2 files changed

Lines changed: 5 additions & 9 deletions

File tree

‎src/clientdlg.cpp‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -268,10 +268,11 @@ CClientDlg::CClientDlg ( CClient* pNCliP,
268268
const int iCurAudReverb = pClient->GetReverbLevel();
269269
sldAudioReverb->setValue ( iCurAudReverb );
270270
sldAudioReverb->setTickInterval ( AUD_REVERB_MAX / 5 );
271+
#endif
271272

272-
// init reverb channel
273+
// init reverb channel (needed for pan feature as well)
273274
UpdateRevSelection();
274-
#endif
275+
275276
// init input boost
276277
pClient->SetInputBoost ( pSettings->iInputBoost );
277278

@@ -688,9 +689,9 @@ void CClientDlg::ManageDragNDrop ( QDropEvent* Event, const bool bCheckAccept )
688689
}
689690
}
690691
}
691-
#ifndef NO_REVERB
692692
void CClientDlg::UpdateRevSelection()
693693
{
694+
#ifndef NO_REVERB
694695
if ( pClient->GetAudioChannels() == CC_STEREO )
695696
{
696697
// for stereo make channel selection invisible since
@@ -714,11 +715,10 @@ void CClientDlg::UpdateRevSelection()
714715
rbtReverbSelR->setChecked ( true );
715716
}
716717
}
717-
718+
#endif
718719
// update visibility of the pan controls in the audio mixer board (pan is not supported for mono)
719720
MainMixerBoard->SetDisplayPans ( pClient->GetAudioChannels() != CC_MONO );
720721
}
721-
#endif
722722
void CClientDlg::OnConnectDlgAccepted()
723723
{
724724
// We had an issue that the accepted signal was emit twice if a list item was double

‎src/clientdlg.h‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,7 @@ class CClientDlg : public CBaseDlg, private Ui_CClientDlgBase
114114
void ShowChatWindow ( const bool bForceRaise = true );
115115
void ShowAnalyzerConsole();
116116
void UpdateAudioFaderSlider();
117-
#ifndef NO_REVERB
118117
void UpdateRevSelection();
119-
#endif
120118
void ManageDragNDrop ( QDropEvent* Event, const bool bCheckAccept );
121119
void SetPingTime ( const int iPingTime, const int iOverallDelayMs, const CMultiColorLED::ELightColor eOverallDelayLEDColor );
122120

@@ -262,9 +260,7 @@ public slots:
262260
void SetMixerBoardDeco ( const ERecorderState newRecorderState, const EGUIDesign eNewDesign );
263261
void OnAudioChannelsChanged()
264262
{
265-
#ifndef NO_REVERB
266263
UpdateRevSelection();
267-
#endif
268264
}
269265
void OnNumClientsChanged ( int iNewNumClients );
270266

0 commit comments

Comments
 (0)