Account completion does not suggest account names specified with the `account` directive or periodic (budget) transactions

[RyanGibb]

For example, in the following file:

account Expenses:Food
account Expenses:Rent
account Expenses:Hobbies                                account Assets

~ monthly
  Expenses:Food               £1
  Assets

2024-07-12 rent
  Expenses:Rent              £1
  Assets

2024-07-12 hobbies
   Expenses:Hobbies           £1
  Assets

I would expect the Expenses:Food account name to be autocompleted, but it's not included in the suggestions:

[RyanGibb]

I haven't looked at the code yet but it seems like the --add-budget option on the accounts command might be relevant here:

$ ledger -f test.ledger accounts
Assets
Expenses:Hobbies
Expenses:Rent
$ ledger -f test.ledger accounts --add-budget
Assets
Expenses:Food
Expenses:Hobbies
Expenses:Rent

This doesn't include accounts specified with the accounts directive, but does include budgeted accounts.

[RyanGibb]

Ah-ha! Looks like ledger_accounts_cmd = 'ledger accounts --add-budget fixes this for accounts included in a budget at least`. Perhaps this should be the default?

[alerque]

I think the real bug here is that ledger is not listing accounts that you've explicitly declared in it's accounts subcommand output. Getting these based on usage in budget transactions is kind of a round-about way to address this when you're also explicitly declaring the account.

Note that hledger accounts does list accounts you declare that way.

[alerque]

I've opened this upstream with Ledger CLI since I really think it should be it's responsibility to provide you a decent list of items to be completed.

ledger/ledger#2519

Additionally I'll add the --add-budget flag since that seems to make sense for when account declarations are not used, then I'll close this because it should be entirely resolved when upstream changes their output.

[RyanGibb]

Thank you!