Aclp logs support by sjer-akamai · Pull Request #686 · linode/linode_api4-python

sjer-akamai · 2026-04-23T11:25:39Z

📝 Description

Adds support for monitor logs functionality
What does this PR do and why is this change necessary?

Adds full SDK support for monitor Logs API. This includes both the destinations and streams. This is a new feature not yet supported in the SDK.
Adds unit tests for newly implemented features.
Adds integration tests for newly implemented features.
Integration tests include safeguards based around the limitations of API.
- The feature is currently in limited availability, these integration tests are skipped if the feature is not available for the account running tests.
- Logs Stream functionality is limited to one stream per account. For this reason Logs stream tests will automatically skip if there's a stream existing on the account.
- Full e2e test for streams require a stream to complete provisioning - based on experience during development this can take up to an hour. Similarly to what's already present for database related tests, an environment variable (run_aclp_logs_stream_tests) needs to be set as true or yes to enable testing the Stream portion of the API.
github workflow files were updated to include the run_aclp_logs_stream_tests environment variable.

Notes:

Techdocs for stream POST and PUT requests mention destinations being "One or more unique identifiers for the sync points that will receive logs data." This differs from the actual API implementation: streams currently support only a single destination, and the API expects a single-element list in the request. This was confirmed with the team developing the ACLP Logs API, and a documentation update was requested.

✔️ How to Test

How do I run the relevant unit/integration tests?
Unit tests:

Follow usual installation/setup steps
run pytest test/unit to run all unit tests, or:
run pytest test/unit/objects/monitor_test.py to run only monitor related tests

Integration tests:

setup your linode token:
- export LINODE_TOKEN="YOUR_REAL_TOKEN"
set environment variable to enable Logs Stream tests. This step is optional - if the variable is not set only destination related tests will run.
- export RUN_ACLP_LOGS_STREAM_TESTS=true
run test suite:
- make TEST_CASE=test_monitor_logs test-int

Notes:

Integration tests will be skipped if account has no Akamai Cloud Pulse Logs account capability
Stream integration tests will be skipped if another Logs stream is present on the account

…ard if stream already exists

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…coped fixture for deterministic execution

…istory

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

sjer-akamai · 2026-04-29T06:32:06Z

Added missing signature to the commit, CI fails on lint because of PR title. Should I change it to something specific?

yec-akamai · 2026-04-29T15:15:50Z

Added missing signature to the commit, CI fails on lint because of PR title. Should I change it to something specific?

Just added label to your PR to pass the CI

…ates

…ions

yec-akamai · 2026-05-13T16:18:43Z

+        "version": Property(),
+    }
+
+    def update_destinations(self, destinations: List[int]):


I wonder why is it necessary to have a separate function to update destinations? You can just mark it as a mutable property, and we can handle it as other updatable field.

It boils down to the API being asymmetric for the destination update - the request takes only a (single element) list of destination ids as opposed to a whole destination object in general. Marking the field as mutable would make the whole LogsStreamDestination mutable and serialized for requests which would fail on API end. I think this was a cleaner solution than having a mutable property and then overriding the save and _serialize - with the mutable property user could call something like stream.destinations[0].label = "new_label" call stream.save() and expect the destination to be modified, but it'll be silently ignored. This version seems to match the actual API capabilities

yec-akamai

Tested and works well locally, nice work!

sjer-akamai and others added 27 commits April 23, 2026 10:27

Add destination API models for monitor objects

63bb91b

Add destination API support in monitor group

be7d021

Destination.history client call fix

66aa467

access_key_secret parameter name fixes

c6dbb16

Add unit tests

297a080

Rename Destination to LogsDestination

0f58fd6

Add integration tests

5a05955

Typo fix

f20535a

Integration tests tweaks

e220822

Documentation tweaks

f275874

Add negative integration test cases

5e6be84

Fix assertion

df5f8c7

Formatting tweaks

cf5c2e2

ACLP Logs stream - add model and group

e70a0e6

ACLP Logs Stream - unit tests

c6f5331

ACLP Logs stream - add integration tests

aaa7aea

ACLP Logs Stream - ensure update reverts on failed assertions

da52b00

ACLP Logs Stream - Formatting tweaks

7544892

ACLP Logs Stream - copilot review tweaks

76a62af

ACLP Logs Stream - review tweaks - pt. 2

2b53808

ACLP Logs Stream - review tweaks - pt. 3

e0d650f

ACLP Logs Stream - remove redundant comma

0326e3e

ACLP Logs Stream - Merge save() method integration tests, add skip gu…

3b13cec

…ard if stream already exists

Update test/unit/objects/monitor_test.py

05b299e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

ACLP Logs Stream - refactor invalid destination test to use session-s…

2549bf0

…coped fixture for deterministic execution

ACLP Logs - update assertion - stream status not tracked by version h…

ef7c13a

…istory

ACLP Logs - update e2e tests workflow

2d4a217

sjer-akamai requested review from a team as code owners April 23, 2026 11:25

sjer-akamai removed the request for review from a team April 23, 2026 11:25

Update linode_api4/objects/monitor.py

b1f7ea0

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

mawilk90 requested a review from psnoch-akamai April 27, 2026 07:24

ACLP Logs - Clarify LogsDestinationType supporting only one value

cdf2c04

sjer-akamai force-pushed the ACLP-logs-support branch from b2de6cd to cdf2c04 Compare April 29, 2026 06:07

yec-akamai added community-contribution for contributions made by a non-DX author new-feature for new features in the changelog. labels Apr 29, 2026

sjer-akamai added 7 commits April 30, 2026 08:54

ACLP Logs - Fix formatting

bf57354

ACLP Logs - Extend destination API with new updates

29fe847

ACLP Logs - Extend Stream API with lke_audit_logs_type, reorder tests

7836172

ACLP Logs - fix __all__ statement

a973cdf

ACLP Logs - Stabilize stream tests

e12157d

ACLP Logs - Reduce integration tests runtime - remove unnecessary upd…

9c190c0

…ates

Merge branch 'dev' into ACLP-logs-support

4cc8da9

yec-akamai reviewed May 5, 2026

View reviewed changes

Comment thread test/integration/models/monitor/test_monitor_logs.py Outdated

sjer-akamai added 5 commits May 6, 2026 09:13

ACLP Logs - Remove integration tests capability check

2bdb1b2

Merge branch 'dev' into ACLP-logs-support

6385d29

ACLP Logs - Stabilize integration tests - loosen status update assert…

4eb8165

…ions

ACLP Logs - Increase timeout for destinations and buckets cleanup

3128387

Merge branch 'dev' into ACLP-logs-support

895d507

sjer-akamai force-pushed the ACLP-logs-support branch from a3e0e27 to d0a00ff Compare May 7, 2026 11:48

ACLP Logs - Increase timeout for destinations and buckets cleanup

0d07f53

sjer-akamai force-pushed the ACLP-logs-support branch from d0a00ff to 0d07f53 Compare May 7, 2026 14:27

ACLP Logs - stabilize integration tests - fix teardown

b53635e

sjer-akamai force-pushed the ACLP-logs-support branch from 8ac29af to b53635e Compare May 11, 2026 13:29

Merge branch 'dev' into ACLP-logs-support

c862205

mawilk90 removed their request for review May 12, 2026 08:54

yec-akamai reviewed May 13, 2026

View reviewed changes

yec-akamai approved these changes May 13, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Aclp logs support#686

Aclp logs support#686
sjer-akamai wants to merge 45 commits into
linode:devfrom
sjer-akamai:ACLP-logs-support

sjer-akamai commented Apr 23, 2026 •

edited

Loading

Uh oh!

sjer-akamai commented Apr 29, 2026

Uh oh!

yec-akamai commented Apr 29, 2026

Uh oh!

Uh oh!

yec-akamai May 13, 2026

Uh oh!

sjer-akamai May 13, 2026

Uh oh!

yec-akamai left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

sjer-akamai commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

✔️ How to Test

Uh oh!

sjer-akamai commented Apr 29, 2026

Uh oh!

yec-akamai commented Apr 29, 2026

Uh oh!

Uh oh!

yec-akamai May 13, 2026

Choose a reason for hiding this comment

Uh oh!

sjer-akamai May 13, 2026

Choose a reason for hiding this comment

Uh oh!

yec-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sjer-akamai commented Apr 23, 2026 •

edited

Loading