Skip to content

Commit 68e6399

Browse files
author
Jelte Lagendijk
committed
Fix deprecated methods & subscriptions
1 parent f952120 commit 68e6399

4 files changed

Lines changed: 16 additions & 10 deletions

File tree

package.json

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
11
{
22
"name": "FileDocumentViewer",
3-
"version": "2.2.3",
3+
"version": "2.2.4",
44
"description": "This widget lets you view file documents.",
55
"license": "",
66
"author": "",
77
"private": true,
8-
"dependencies": {
9-
},
8+
"dependencies": {},
109
"devDependencies": {
1110
"del": "^2.2.2",
1211
"gulp": "^3.9.1",
@@ -35,4 +34,4 @@
3534
"folders": "node ./node_modules/gulp/bin/gulp folders",
3635
"modeler": "node ./node_modules/gulp/bin/gulp modeler"
3736
}
38-
}
37+
}

src/FileDocumentViewer/widget/FileDocumentViewer.js

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ require( [
6868
this._resetSubscriptions();
6969
this._updateRendering(callback);
7070
} else {
71-
mendix.lang.nullExec(callback);
71+
this._executeCallback(callback, "update");
7272
}
7373
},
7474

@@ -94,18 +94,18 @@ require( [
9494
domAttr.set(this.headerTextNode, "innerHTML","...");
9595
}
9696

97-
mendix.lang.nullExec(callback);
97+
this._executeCallback(callback, "_updateRendering");
9898
},
9999

100100
_resetSubscriptions: function () {
101101
logger.debug(this.id + "._resetSubscriptions");
102102
if (this._handle) {
103-
mx.data.unsubscribe(this._handle);
103+
this.unsubscribe(this._handle);
104104
this._handle = null;
105105
}
106106

107107
if (this._contextObj) {
108-
this._handle = mx.data.subscribe({
108+
this._handle = this.subscribe({
109109
guid: this._contextObj.getGuid(),
110110
callback: lang.hitch(this, function () {
111111
this._updateRendering();
@@ -143,10 +143,17 @@ require( [
143143

144144
uninitialize: function () {
145145
if (this._handle) {
146-
mx.data.unsubscribe(this._handle);
146+
this.unsubscribe(this._handle);
147147
this._handle = null;
148148
}
149149
logger.debug(this.id + ".uninitialize");
150+
},
151+
152+
_executeCallback: function (cb, from) {
153+
logger.debug(this.id + "._executeCallback" + (from ? " from " + from : ""));
154+
if (cb && typeof cb === "function") {
155+
cb();
156+
}
150157
}
151158
});
152159
});

src/package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<package xmlns="http://www.mendix.com/package/1.0/">
3-
<clientModule name="FileDocumentViewer" version="2.2.3" xmlns="http://www.mendix.com/clientModule/1.0/">
3+
<clientModule name="FileDocumentViewer" version="2.2.4" xmlns="http://www.mendix.com/clientModule/1.0/">
44
<widgetFiles>
55
<widgetFile path="FileDocumentViewer/FileDocumentViewer.xml"/>
66
</widgetFiles>
-153 KB
Binary file not shown.

0 commit comments

Comments
 (0)