Skip to content

Conversation

@karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Mar 22, 2021

For #15717

@karthiknadig karthiknadig changed the title Remove exports from un-used exported functions, classes, and constants Remove export from un-used exported functions, classes, and constants Mar 22, 2021
@codecov-io
Copy link

Codecov Report

Merging #15741 (e81c752) into main (3ca66f9) will increase coverage by 0%.
The diff coverage is 80%.

@@           Coverage Diff           @@
##            main   #15741    +/-   ##
=======================================
  Coverage     64%      65%            
=======================================
  Files        557      551     -6     
  Lines      26730    26344   -386     
  Branches    3887     3803    -84     
=======================================
- Hits       17292    17236    -56     
+ Misses      8708     8377   -331     
- Partials     730      731     +1     
Impacted Files Coverage Δ
src/client/activation/types.ts 100% <ø> (ø)
.../application/diagnostics/checks/envPathVariable.ts 92% <ø> (-1%) ⬇️
.../diagnostics/checks/invalidPythonPathInDebugger.ts 86% <ø> (-1%) ⬇️
...t/application/diagnostics/checks/lsNotSupported.ts 75% <ø> (-1%) ⬇️
...c/client/application/diagnostics/commands/types.ts 100% <ø> (ø)
src/client/common/installer/productInstaller.ts 24% <ø> (-2%) ⬇️
src/client/common/process/rawProcessApis.ts 10% <0%> (-1%) ⬇️
src/client/common/utils/multiStepInput.ts 9% <ø> (-1%) ⬇️
src/client/common/utils/random.ts 21% <0%> (ø)
src/client/common/utils/sysTypes.ts 54% <0%> (-3%) ⬇️
... and 53 more

@karthiknadig karthiknadig added no-changelog No news entry required skip tests Updates to tests unnecessary labels Mar 22, 2021
@karthiknadig karthiknadig marked this pull request as ready for review March 22, 2021 18:04
@github-actions github-actions bot requested review from karrtikr and kimadeline March 22, 2021 18:04
@karthiknadig karthiknadig merged commit e3e773a into microsoft:main Mar 22, 2021
@karthiknadig karthiknadig deleted the remove-exports branch March 24, 2021 00:40
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 80.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 65%. Comparing base (3ca66f9) to head (e81c752).
⚠️ Report is 2370 commits behind head on main.

Files with missing lines Patch % Lines
src/client/pythonEnvironments/info/index.ts 0% 4 Missing ⚠️
src/client/common/process/rawProcessApis.ts 0% 1 Missing ⚠️
src/client/common/utils/random.ts 0% 1 Missing ⚠️
src/client/common/utils/sysTypes.ts 0% 1 Missing ⚠️
src/client/logging/levels.ts 50% 1 Missing ⚠️
src/client/testing/common/runner.ts 0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #15741    +/-   ##
=======================================
  Coverage     64%      65%            
=======================================
  Files        557      551     -6     
  Lines      26730    26344   -386     
  Branches    3887     3803    -84     
=======================================
- Hits       17292    17236    -56     
+ Misses      8708     8377   -331     
- Partials     730      731     +1     
Files with missing lines Coverage Δ
.../activation/common/languageServerPackageService.ts 89% <100%> (ø)
src/client/activation/common/packageRepository.ts 100% <100%> (ø)
...ion/languageServer/languageServerPackageService.ts 100% <100%> (ø)
...c/client/activation/languageServer/platformData.ts 75% <100%> (ø)
src/client/activation/types.ts 100% <ø> (ø)
.../application/diagnostics/checks/envPathVariable.ts 92% <ø> (-1%) ⬇️
.../diagnostics/checks/invalidPythonPathInDebugger.ts 86% <ø> (-1%) ⬇️
...t/application/diagnostics/checks/lsNotSupported.ts 75% <ø> (-1%) ⬇️
...c/client/application/diagnostics/commands/types.ts 100% <ø> (ø)
src/client/common/installer/productInstaller.ts 24% <ø> (-2%) ⬇️
... and 40 more

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required skip tests Updates to tests unnecessary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants