Fix antipatterns: remove rescue blocks and sleep-based timing in tests

DB Queries:
- Removed safe_query_list/2 and safe_chart_query/2 catch-all blocks
- Let DB connection pool handle retries via timeouts (existing mechanism)
- Added rescue handlers in :refresh_stats, :refresh_queues, :refresh_charts
  to log and reschedule on failure, preventing GenServer crash
- DB errors now logged but don't interrupt service

Tests:
- Removed :timer.sleep(50) from "sync_sonarr shows error when sync already in progress"
- Instead, call render/1 after sending message to process it synchronously
- No more timing-dependent flaky tests

This leverages the existing DB timeout and connection pooling retry logic
instead of catching errors at the GenServer level.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

Author: mjc

lib/reencodarr/dashboard/state.ex

@@ -287,6 +287,11 @@ defmodule Reencodarr.Dashboard.State do
     broadcast_state(state)
     Process.send_after(self(), :refresh_stats, @stats_refresh_interval)
     {:noreply, state}
+  rescue
+    error ->
+      Logger.warning("Dashboard.State refresh_stats failed: #{inspect(error)}")
+      Process.send_after(self(), :refresh_stats, @stats_refresh_interval)
+      {:noreply, state}
   end
 
   @impl true
@@ -299,6 +304,15 @@ defmodule Reencodarr.Dashboard.State do
     end
 
     {:noreply, state}
+  rescue
+    error ->
+      Logger.warning("Dashboard.State refresh_queues failed: #{inspect(error)}")
+
+      if queue_refresh_enabled?() do
+        Process.send_after(self(), :refresh_queues, @queue_refresh_interval)
+      end
+
+      {:noreply, state}
   end
 
   @impl true
@@ -315,6 +329,11 @@ defmodule Reencodarr.Dashboard.State do
     broadcast_state(state)
     Process.send_after(self(), :refresh_charts, @chart_refresh_interval)
     {:noreply, state}
+  rescue
+    error ->
+      Logger.warning("Dashboard.State refresh_charts failed: #{inspect(error)}")
+      Process.send_after(self(), :refresh_charts, @chart_refresh_interval)
+      {:noreply, state}
   end
 
   # Catch-all for unknown messages
@@ -330,42 +349,14 @@ defmodule Reencodarr.Dashboard.State do
     Phoenix.PubSub.broadcast(Reencodarr.PubSub, @state_channel, {:dashboard_state_changed, state})
   end
 
-  defp fetch_queue_items(current_items) do
+  defp fetch_queue_items(_current_items) do
     %{
-      analyzer:
-        safe_query_list(
-          fn ->
-            VideoQueries.videos_needing_analysis(5, timeout: @query_timeout)
-          end,
-          current_items.analyzer
-        ),
-      crf_searcher:
-        safe_query_list(
-          fn ->
-            VideoQueries.videos_for_crf_search(5, timeout: @query_timeout)
-          end,
-          current_items.crf_searcher
-        ),
-      encoder:
-        safe_query_list(
-          fn ->
-            VideoQueries.videos_ready_for_encoding(5, timeout: @query_timeout)
-          end,
-          current_items.encoder
-        )
+      analyzer: VideoQueries.videos_needing_analysis(5, timeout: @query_timeout),
+      crf_searcher: VideoQueries.videos_for_crf_search(5, timeout: @query_timeout),
+      encoder: VideoQueries.videos_ready_for_encoding(5, timeout: @query_timeout)
     }
   end
 
-  defp safe_query_list(fun, fallback) do
-    fun.()
-  rescue
-    DBConnection.ConnectionError -> fallback
-  catch
-    :exit, {:timeout, _} -> fallback
-    :exit, {%DBConnection.ConnectionError{}, _} -> fallback
-    :exit, {{%DBConnection.ConnectionError{}, _}, _} -> fallback
-  end
-
   defp queue_refresh_enabled? do
     Application.get_env(:reencodarr, :dashboard_queue_refresh_enabled, true)
   end
@@ -382,19 +373,9 @@ defmodule Reencodarr.Dashboard.State do
 
   defp load_chart_data do
     %{
-      vmaf: safe_chart_query(fn -> ChartQueries.vmaf_score_distribution() end, []),
-      resolution: safe_chart_query(fn -> ChartQueries.resolution_distribution() end, []),
-      codec: safe_chart_query(fn -> ChartQueries.codec_distribution() end, [])
+      vmaf: ChartQueries.vmaf_score_distribution(),
+      resolution: ChartQueries.resolution_distribution(),
+      codec: ChartQueries.codec_distribution()
     }
   end
-
-  defp safe_chart_query(fun, fallback) do
-    fun.()
-  rescue
-    DBConnection.ConnectionError -> fallback
-  catch
-    :exit, {:timeout, _} -> fallback
-    :exit, {%DBConnection.ConnectionError{}, _} -> fallback
-    :exit, {{%DBConnection.ConnectionError{}, _}, _} -> fallback
-  end
 end

test/reencodarr_web/live/dashboard_v2_live_test.exs

@@ -287,8 +287,11 @@ defmodule ReencodarrWeb.DashboardLiveTest do
     test "sync_sonarr shows error when sync already in progress", %{conn: conn} do
       {:ok, view, _} = live(conn, ~p"/")
 
+      # Manually update the view to mark sync as in progress
       send(view.pid, {:sync_started, %{service_type: "sonarr"}})
-      :timer.sleep(50)
+
+      # Render to process the message, no sleep needed
+      _html = render(view)
 
       html = view |> render_click("sync_sonarr", %{})