Fixed unittest helm plugin

Author: lsierant

Makefile

@@ -300,8 +300,11 @@ test: generate fmt vet manifests golang-tests
 # helm-tests will run helm chart unit tests
 helm-tests:
 	@echo "Running helm chart unit tests..."
-	@if ! helm plugin list | grep -q unittest; then \
-		echo "Installing helm-unittest plugin..."; \
+	helm version
+	helm plugin list || true
+	@if ! helm unittest --help >/dev/null 2>&1; then \
+		echo "helm-unittest plugin not working/not installed, reinstalling..."; \
+		helm plugin uninstall unittest 2>/dev/null || true; \
 		helm plugin install https://github.com/helm-unittest/helm-unittest; \
 	fi
 	helm unittest helm_chart --color

scripts/dev/contexts/root-context

@@ -153,3 +153,6 @@ export RELEASE_INITIAL_VERSION="1.3.0"
 
 export CLUSTER_TYPE=kind
 export OPERATOR_CLUSTER_SCOPED=false
+
+# for downloading helm binaries
+export HELM_VERSION="v3.19.4"

scripts/dev/setup_evg_host.sh

@@ -56,7 +56,7 @@ download_kubectl() {
 
 download_helm() {
   echo "Downloading helm..."
-  curl -s -o helm.tar.gz -L https://get.helm.sh/helm-v3.17.1-linux-"${ARCH}"tar.gz
+  curl -s -o helm.tar.gz -L "https://get.helm.sh/helm-${HELM_VERSION}-linux-${ARCH}tar.gz"
   tar -xf helm.tar.gz 2>/dev/null
   sudo mv linux-"${ARCH}"helm /usr/local/bin/helm
   rm helm.tar.gz

scripts/evergreen/setup_kubectl.sh

@@ -22,10 +22,9 @@ echo "kubectl version --client"
 ./kubectl version --client
 mv kubectl "${bindir}"
 
-echo "Downloading helm for ${ARCH}"
+echo "Downloading helm ${HELM_VERSION} for ${ARCH}"
 helm_archive="${tmpdir}/helm.tgz"
-helm_version="v3.17.1"
-curl --retry 5 --retry-delay 3 --retry-all-errors --fail --show-error --max-time 180 -s https://get.helm.sh/helm-${helm_version}-linux-"${ARCH}".tar.gz --output "${helm_archive}"
+curl --retry 5 --retry-delay 3 --retry-all-errors --fail --show-error --max-time 180 -s "https://get.helm.sh/helm-${HELM_VERSION}-linux-${ARCH}.tar.gz" --output "${helm_archive}"
 
 tar xfz "${helm_archive}" -C "${tmpdir}" &> /dev/null
 mv "${tmpdir}/linux-${ARCH}/helm" "${bindir}"