Fix quota usage to not rely on get_collection_id

[data-sync-user]

get_collection_id should be a test only method but it’s currently used in the post_collection_batch handler for calling get_quota_usage, which should change its parameters to not include a collection_id.

┆Issue is synchronized with this Jira Task

[data-sync-user]

➤ Barry Chen commented:

The queries should be updated to use GetQuotaUsage::collection in their where conditions then, correct?

[data-sync-user]

➤ Barry Chen commented:

err Philip Jenvey

[data-sync-user]

➤ Philip Jenvey commented:

Barry Chen Sorry, we use get_collection_id in a lot of places within the impls, I meant to say it’s solely used outside of the impls in this one place for get_quota_usage.

So the query should stay the same, but would still use a collection_id via calling get_collection_id internally like the other methods.

You’ll also need to rename the internal methods to _get_collection_id, which the test only trait method would call (create_collection/_create_collection are already work like this).