Skip to content

Detect commandeered revisions #384

Description

@tomrittervg

In Bug 1930832 a developer commandeered a phab revision (which is totally fine and encouraged) and later Updatebot tried to abandon it, which failed when it couldn't. The error it got back from phabricator was:

Got an error from phabricator when trying to abandon 228765: {'error': 'ERR-CONDUIT-CORE', 'errorMessage': 'ERR-CONDUIT-CORE: <differential.revision.edit> Validation errors:\n  - You can not abandon this revision because you are not the author. You can only abandon revisions you own. You can change this behavior by adjusting the "differential.always-allow-abandon" setting in Config.', 'response': None}

We could detect this error and handle it more gracefully.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions