From 068b1bc80668b1482c9fbb8f034742ab0027052f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Troed=20S=C3=A5ngberg?= Date: Fri, 12 Jun 2026 13:35:44 +0200 Subject: [PATCH] fix(gui): prevent nullptr dereference when VFS mode is unavailable in askExperimentalVirtualFilesFeature MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The switch statement on Vfs::Mode lacked a default case. When an unexpected VFS mode is returned, msgBox remains nullptr and msgBox->open() causes a segfault. Added a default case that calls callback(false) and returns early. Assisted-by: Qwen:qwen-3.6-35b-a3b Signed-off-by: Troed Sångberg --- src/gui/guiutility.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/gui/guiutility.cpp b/src/gui/guiutility.cpp index f1bb11732a825..c56bbe456d5e7 100644 --- a/src/gui/guiutility.cpp +++ b/src/gui/guiutility.cpp @@ -149,6 +149,10 @@ void Utility::askExperimentalVirtualFilesFeature(QWidget *receiver, const std::f case Vfs::XAttr: case Vfs::Off: Q_UNREACHABLE(); + default: + // Unhandled VFS mode - don't show the dialog + callback(false); + return; } QObject::connect(msgBox, &QMessageBox::accepted, receiver, [callback, msgBox, acceptButton] {