Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jan 19, 2026

Summary

The XHR error handling was duplicated, as we already handle this in core/src/init.js where we intercept Fetch API and XHR API. So we can drop this jQuery specific duplicate.

Checklist

@susnux susnux requested a review from a team as a code owner January 19, 2026 14:17
@susnux susnux added 3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Jan 19, 2026
@susnux susnux requested review from artonge, nfebe and szaimen and removed request for a team January 19, 2026 14:17
@susnux susnux added this to the Nextcloud 33 milestone Jan 19, 2026
@susnux susnux requested a review from CarlSchwan January 19, 2026 14:17
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

The XHR error handling was duplicated, as we already handle this in
`core/src/init.js` where we intercept Fetch API and XHR API.
So we can drop this jQuery specific duplicate.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
Copy link
Contributor Author

susnux commented Jan 19, 2026

/compile

Signed-off-by: nextcloud-command <[email protected]>
@susnux susnux merged commit 772471d into master Jan 19, 2026
134 of 137 checks passed
@susnux susnux deleted the chore/xhr branch January 19, 2026 16:09
@susnux susnux added the pending documentation This pull request needs an associated documentation update label Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants