Skip to content

Commit 21f0f27

Browse files
authored
src: remove --harmony-import-attributes
Import attributes have been enabled by default since V8 M123 and are now standard in JavaScript. Remove the hardcoded injection of the flag in Node.js so that the flag can be deprecated and removed upstream in V8. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/8260695 Signed-off-by: Olivier Flückiger <olivf@chromium.org> PR-URL: #65396 Refs: #61898 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 11a9998 commit 21f0f27

1 file changed

Lines changed: 0 additions & 7 deletions

File tree

src/node.cc

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -759,13 +759,6 @@ static ExitCode ProcessGlobalArgsInternal(std::vector<std::string>* args,
759759
return ExitCode::kInvalidCommandLineArgument2;
760760
}
761761

762-
// TODO(aduh95): remove this when the harmony-import-attributes flag
763-
// is removed in V8.
764-
if (std::ranges::find(v8_args, "--no-harmony-import-attributes") ==
765-
v8_args.end()) {
766-
v8_args.emplace_back("--harmony-import-attributes");
767-
}
768-
769762
if (!per_process::cli_options->per_isolate->max_old_space_size_percentage
770763
.empty()) {
771764
v8_args.emplace_back(

0 commit comments

Comments
 (0)