-
Notifications
You must be signed in to change notification settings - Fork 575
Typos in documentation #4110
Copy link
Copy link
Closed
Labels
bugSomething isn't workingSomething isn't workingneeds-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingneeds-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Page: https://opentelemetry-cpp.readthedocs.io/en/latest/otel_docs/structopentelemetry_1_1sdk_1_1metrics_1_1PeriodicExportingMetricReaderOptions.html
A quick find and spell points to at least 2 locations where it is Exorting instead of Exporting:
./sdk/include/opentelemetry/sdk/metrics/export/periodic_exporting_metric_reader_options.h: * Struct to hold PeriodicExortingMetricReader options.
./sdk/include/opentelemetry/sdk/metrics/export/periodic_exporting_metric_reader_runtime_options.h: * Struct to hold PeriodicExortingMetricReader runtime options.
Other typos, possibly not relevant to documentation:
$ find . -name '.h' | xargs grep -E "stroage|unnescessary|Contruct|preroccessor|Exorting"
./sdk/include/opentelemetry/sdk/common/attribute_utils.h: // Contruct empty attribute map
./sdk/include/opentelemetry/sdk/common/attribute_utils.h: // Contruct attribute map and populate with attributes
./sdk/include/opentelemetry/sdk/metrics/multi_observer_result.h: // This allows us to avoid an unnescessary layer of inderection and a bunch of allocations.
./sdk/include/opentelemetry/sdk/metrics/state/metric_storage.h:/ Represents the async metric stroage */