Ideas for cleaning up the public profile view?

[zven]

I just set my profile on staging to public and it looks pretty much like when I am logged in, which is confusing.

Logged in:

Not logged in (public view):

• Even when I am not logged in, I can see the whole context menu (including Edit, Support etc.)
• The Logout icon on the top right actually leads me to another login view.

Shall we strip this down in some way?

[scheidtdav]

👍 for removing some stuff in case of the public profile.
I'd say the context menu should probably hide everything but "Overview" and "show on map" maybe?
Careful: Overview shouldn't leak the device security key.

🚨 🚨 I was able to edit on of @zven devices via the public profile while being logged into mine.
That should definitely not be possible!!

[zven]

Issue: #786

[scheidtdav]

This is only for the 🚨 part of my above comment, right?

[zven]

Nope, also for the context menu. ;-) But I see that you fixed that as well :-)

[zven]

@scheidtdav Where should Overview take me in the case I am not logged in / logged in with a different user?

When I am not logged in, only get redirected to https://staging.opensensemap.org. 🤔

[scheidtdav]

good point. I suppose the device overview page would be good, as you might be interested in sensor ids etc.
I am thinking about a kind of profile page but for a device.
Obviously it shouldn't leak sensitive data like the device api key though. Not sure if it makes sense? Maybe showing on map is enough? Then it shouldn't be an overflow menu though, right?

[zven]

I think just linking to map view would be fine. 🤔

[scheidtdav]

@zven Did a quick PR here.

[scheidtdav]

@zven Can we close this for now?

[zven]

Yes, we can! ;-)