Skip to content

Refactor set-children function in children_hotkeys.py #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eureka928 wants to merge 12 commits into from
+824 −73
Closed

Refactor set-children function in children_hotkeys.py #782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bbb3c93
feat: refactor the set_children function
eureka928 Dec 22, 2025
eeb1e98
feat: add testing for set_children
eureka928 Dec 22, 2025
db96bef
fix: remove the parent hotkey
eureka928 Dec 22, 2025
048cf5b
fix: update to print_error
eureka928 Dec 22, 2025
6dba509
fix: update the testing
eureka928 Dec 22, 2025
2a1421c
fix: update the test
eureka928 Dec 22, 2025
ae383e2
ruff format
eureka928 Dec 22, 2025
5054d97
fix: update the test of test_set_children_multiple_proportions
eureka928 Dec 22, 2025
fd8b7e0
ruff format and add revoke test
eureka928 Dec 22, 2025
e7adc0e
fix: remove the revoke child test
eureka928 Dec 22, 2025
3343801
fix: update the get children function
eureka928 Dec 22, 2025
2344dc6
fix: remove the parent-hotkey which is redundent with wallet hotkey
eureka928 Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bittensor_cli/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6247,6 +6247,7 @@ def stake_set_children(
ask_for=[WO.NAME, WO.HOTKEY],
validate=WV.WALLET_AND_HOTKEY,
)

logger.debug(
"args:\n"
f"network: {network}\n"
Expand Down
120 changes: 57 additions & 63 deletions bittensor_cli/src/commands/stake/children_hotkeys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import asyncio
import json
from typing import Optional
from typing import Optional, Any

from bittensor_wallet import Wallet
from rich.prompt import IntPrompt, FloatPrompt
Expand Down Expand Up @@ -499,10 +499,14 @@ async def _render_table(
)
if not success:
print_error(f"Failed to get children from subtensor: {err_mg}")

# Always render the table, even if there are no children
if children:
netuid_children_tuples = [(netuid, children)]
await _render_table(get_hotkey_pub_ss58(wallet), netuid_children_tuples)
else:
netuid_children_tuples = []

await _render_table(get_hotkey_pub_ss58(wallet), netuid_children_tuples)
return children


Expand All @@ -518,96 +522,86 @@ async def set_children(
json_output: bool = False,
proxy: Optional[str] = None,
):
"""Set children hotkeys."""
# TODO holy shit I hate this. It needs to be rewritten.
"""
Set children hotkeys with proportions for a parent hotkey on specified subnet(s).

Args:
wallet: Wallet containing the coldkey for signing transactions.
subtensor: SubtensorInterface instance for blockchain interaction.
children: List of child hotkey SS58 addresses.
proportions: List of stake proportions (floats between 0 and 1).
netuid: Optional specific subnet ID. If None, operates on ALL non-root subnets.
wait_for_inclusion: Wait for transaction to be included in a block.
wait_for_finalization: Wait for transaction to be finalized.
prompt: Prompt user for confirmation before submitting transactions.
json_output: Output results as JSON instead of formatted text.
proxy: Optional proxy SS58 address for transaction submission.
"""
parent_hotkey = get_hotkey_pub_ss58(wallet)

# Validate children SS58 addresses
# TODO check to see if this should be allowed to be specified by user instead of pulling from wallet
hotkey = get_hotkey_pub_ss58(wallet)
for child in children:
if not is_valid_ss58_address(child):
print_error(f"Invalid SS58 address: {child}")
msg = f"Invalid SS58 address: {child}"
print_error(msg)
if json_output:
json_console.print(json.dumps({"success": False, "message": msg}))
return
if child == hotkey:
print_error("Cannot set yourself as a child.")
if child == parent_hotkey:
msg = "Cannot set yourself as a child."
print_error(msg)
if json_output:
json_console.print(json.dumps({"success": False, "message": msg}))
return

total_proposed = sum(proportions)
if total_proposed > 1:
raise ValueError(
f"Invalid proportion: The sum of all proportions cannot be greater than 1. "
f"Proposed sum of proportions is {total_proposed}."
)
children_with_proportions = list(zip(proportions, children))
successes = {}

# Determine netuids
if netuid is not None:
netuids = [netuid]
else:
all_netuids = await subtensor.get_all_subnet_netuids()
netuids = [n for n in all_netuids if n != 0]

# Execute operations
dict_output = {}
for netuid_ in netuids:
success, message, ext_id = await set_children_extrinsic(
subtensor=subtensor,
wallet=wallet,
netuid=netuid,
hotkey=hotkey,
netuid=netuid_,
hotkey=parent_hotkey,
proxy=proxy,
children_with_proportions=children_with_proportions,
prompt=prompt,
wait_for_inclusion=wait_for_inclusion,
wait_for_finalization=wait_for_finalization,
)
successes[netuid] = {
dict_output[netuid_] = {
"success": success,
"error": message,
"completion_block": None,
"error": message,
"set_block": None,
"extrinsic_identifier": ext_id,
}
# Result

if success:
if wait_for_inclusion and wait_for_finalization:
current_block, completion_block = await get_childkey_completion_block(
subtensor, netuid
)
successes[netuid]["completion_block"] = completion_block
successes[netuid]["set_block"] = current_block
console.print(
f"Your childkey request has been submitted. It will be completed around block {completion_block}. "
f"The current block is {current_block}"
)
print_success("Set children hotkeys.")
else:
print_error(f"Unable to set children hotkeys. {message}")
else:
# set children on all subnets that parent is registered on
netuids = await subtensor.get_all_subnet_netuids()
for netuid_ in netuids:
if netuid_ == 0: # dont include root network
continue
console.print(f"Setting children on netuid {netuid_}.")
success, message, ext_id = await set_children_extrinsic(
subtensor=subtensor,
wallet=wallet,
netuid=netuid_,
hotkey=hotkey,
proxy=proxy,
children_with_proportions=children_with_proportions,
prompt=prompt,
wait_for_inclusion=True,
wait_for_finalization=False,
)
current_block, completion_block = await get_childkey_completion_block(
subtensor, netuid_
)
successes[netuid_] = {
"success": success,
"error": message,
"completion_block": completion_block,
"set_block": current_block,
"extrinsic_identifier": ext_id,
}
dict_output[netuid_]["set_block"] = current_block
dict_output[netuid_]["completion_block"] = completion_block
console.print(
f"Your childkey request for netuid {netuid_} has been submitted. It will be completed around "
f"block {completion_block}. The current block is {current_block}."
f":white_heavy_check_mark: Your childkey request for netuid {netuid_} has been submitted. "
f"It will be completed around block {completion_block}. The current block is {current_block}"
)
else:
print_error(
f"Failed to set children hotkeys for netuid {netuid_}: {message}"
)
print_success("Sent set children request for all subnets.")

if json_output:
json_console.print(json.dumps(successes))
json_console.print(json.dumps(dict_output))


async def revoke_children(
Expand Down
Loading