Commit 87cbb3e
Blast propagation proto removal (#3971)
Reserve `BlastPropagation` and `followOnlyBlastPropagation` fields from
SDP protos to maintain wire-format compatibility and update
documentation and tests to reflect their deprecation.
This PR completes Phase 3 of the "Remove Blast Propagation Information"
project (ENG-2404), following the prior code removal (ENG-2647). It
ensures that old messages can still be parsed safely and prevents
accidental reuse of field numbers.
---
Linear Issue:
[ENG-2404](https://linear.app/overmind/issue/ENG-2404/sdp-reserve-blastpropagation-and-followonlyblastpropagation-from)
<p><a
href="https://cursor.com/agents?id=bc-9c62732b-1a27-42af-abf2-8c9866357e8b"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a
href="https://cursor.com/background-agent?bcId=bc-9c62732b-1a27-42af-abf2-8c9866357e8b"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </p>
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> Touches core protobuf contracts and regenerated client code;
downstream services/clients relying on `blastPropagation` fields or
reverse-edge filtering may break if not updated in lockstep.
>
> **Overview**
> This PR **deprecates and effectively removes blast-propagation
metadata from the SDP surface** by reserving the `BlastPropagation`
fields in `sdp/items.proto` and `sdp/revlink.proto` (and regenerating
Go/TS protobuf outputs) so old messages can still be parsed without
allowing field-number reuse.
>
> It updates sources and tooling to stop setting/expecting
`BlastPropagation` on links (e.g., AWS CloudWatch metric suggested
queries, EC2 address links, snapshot edge→linked-item conversion), and
strips Azure integration tests and docs/prompting guidance that
referenced propagation semantics, reflecting the move to AI-driven blast
radius calculation.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
58035be2747c0f212919a366e08717efd786b30f. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
GitOrigin-RevId: ecdcb08090547689567725f2c37d33617b0456aa1 parent 1a176ab commit 87cbb3e
40 files changed
Lines changed: 82 additions & 872 deletions
File tree
- aws-source/adapters
- go/sdp-go
- sources
- azure/integration-tests
- snapshot/adapters
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | 27 | | |
36 | 28 | | |
37 | 29 | | |
| |||
244 | 236 | | |
245 | 237 | | |
246 | 238 | | |
247 | | - | |
248 | 239 | | |
249 | 240 | | |
250 | 241 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | 37 | | |
46 | 38 | | |
47 | 39 | | |
| |||
62 | 54 | | |
63 | 55 | | |
64 | 56 | | |
65 | | - | |
66 | 57 | | |
67 | 58 | | |
68 | 59 | | |
| |||
76 | 67 | | |
77 | 68 | | |
78 | 69 | | |
79 | | - | |
80 | 70 | | |
81 | 71 | | |
82 | 72 | | |
| |||
88 | 78 | | |
89 | 79 | | |
90 | 80 | | |
91 | | - | |
92 | 81 | | |
93 | 82 | | |
94 | 83 | | |
| |||
100 | 89 | | |
101 | 90 | | |
102 | 91 | | |
103 | | - | |
104 | 92 | | |
105 | 93 | | |
106 | 94 | | |
| |||
112 | 100 | | |
113 | 101 | | |
114 | 102 | | |
115 | | - | |
116 | 103 | | |
117 | 104 | | |
118 | 105 | | |
| |||
124 | 111 | | |
125 | 112 | | |
126 | 113 | | |
127 | | - | |
128 | 114 | | |
129 | 115 | | |
130 | 116 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | 23 | | |
30 | 24 | | |
31 | 25 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments