Updated __eq__ methods to return NotImplemented

Author: ankane

pgvector/bit.py

@@ -57,9 +57,9 @@ def __repr__(self) -> str:
         return f'Bit({self.to_text()})'
 
     def __eq__(self, other: object, /) -> bool:
-        if isinstance(other, self.__class__):
-            return self._length == other._length and self._data == other._data
-        return False
+        if not isinstance(other, self.__class__):
+            return NotImplemented
+        return self._length == other._length and self._data == other._data
 
     def to_list(self) -> list[bool]:
         # TODO improve

pgvector/halfvec.py

@@ -35,9 +35,9 @@ def __repr__(self) -> str:
         return f'HalfVector({self.to_list()})'
 
     def __eq__(self, other: object, /) -> bool:
-        if isinstance(other, self.__class__):
-            return self._value == other._value
-        return False
+        if not isinstance(other, self.__class__):
+            return NotImplemented
+        return self._value == other._value
 
     def dimensions(self) -> int:
         return len(self._value)

pgvector/sparsevec.py

@@ -53,9 +53,9 @@ def __repr__(self) -> str:
         return f'SparseVector({elements}, {self._dim})'
 
     def __eq__(self, other: object, /) -> bool:
-        if isinstance(other, self.__class__):
-            return self._dim == other._dim and self._indices == other._indices and self._values == other._values
-        return False
+        if not isinstance(other, self.__class__):
+            return NotImplemented
+        return self._dim == other._dim and self._indices == other._indices and self._values == other._values
 
     def dimensions(self) -> int:
         return self._dim

pgvector/vector.py

@@ -34,9 +34,9 @@ def __repr__(self) -> str:
         return f'Vector({self.to_list()})'
 
     def __eq__(self, other: object, /) -> bool:
-        if isinstance(other, self.__class__):
-            return self._value == other._value
-        return False
+        if not isinstance(other, self.__class__):
+            return NotImplemented
+        return self._value == other._value
 
     def dimensions(self) -> int:
         return len(self._value)

tests/test_bit.py

@@ -85,6 +85,7 @@ def test_repr(self) -> None:
     def test_equality(self) -> None:
         assert Bit([True, False, True]) == Bit([True, False, True])
         assert Bit([True, False, True]) != Bit([True, False, False])
+        assert Bit([True, False, True]) != 1
 
     def test_from_text(self) -> None:
         vec = Bit.from_text('101')

tests/test_half_vector.py

@@ -54,6 +54,7 @@ def test_repr(self) -> None:
     def test_equality(self) -> None:
         assert HalfVector([1, 2, 3]) == HalfVector([1, 2, 3])
         assert HalfVector([1, 2, 3]) != HalfVector([1, 2, 4])
+        assert HalfVector([1, 2, 3]) != 1
 
     def test_dimensions(self) -> None:
         assert HalfVector([1, 2, 3]).dimensions() == 3

tests/test_sparse_vector.py

@@ -112,6 +112,7 @@ def test_equality(self) -> None:
         assert SparseVector([1, 0, 2, 0, 3, 0]) != SparseVector([1, 0, 2, 0, 3, 1])
         assert SparseVector([1, 0, 2, 0, 3, 0]) == SparseVector({2: 2, 4: 3, 0: 1, 3: 0}, 6)
         assert SparseVector({}, 1) != SparseVector({}, 2)
+        assert SparseVector([1, 0, 2, 0, 3, 0]) != 1
 
     def test_dimensions(self) -> None:
         assert SparseVector([1, 0, 2, 0, 3, 0]).dimensions() == 6

tests/test_vector.py

@@ -54,6 +54,7 @@ def test_repr(self) -> None:
     def test_equality(self) -> None:
         assert Vector([1, 2, 3]) == Vector([1, 2, 3])
         assert Vector([1, 2, 3]) != Vector([1, 2, 4])
+        assert Vector([1, 2, 3]) != 1
 
     def test_dimensions(self) -> None:
         assert Vector([1, 2, 3]).dimensions() == 3