Json last error msg/error message with location error #20629
Merged
+1,453
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
Dec 2, 2025
juan-morales
changed the title
bukka
requested changes
Dec 3, 2025
Member
bukka
left a comment
bukka
left a comment
There was a problem hiding this comment.
It looks mostly good (nicely taken from jso :) ). Just some minor things.
Other than that I like the new format not exposing the content and just showing the location which I think is acceptable without RFC. Previously I was the only one suggesting a new function but I no longer think it's necessary.
Member
|
NEWS and UPGRADING updated in 8422224 |
Contributor
Author
|
I Am so happy |
sebastianbergmann
added a commit
to sebastianbergmann/phpunit
that referenced
this pull request
Jan 4, 2026
sebastianbergmann
added a commit
to sebastianbergmann/phpunit
that referenced
this pull request
Jan 4, 2026
* 10.5: Update test expectation after php/php-src#20629 Update tools
sebastianbergmann
added a commit
to sebastianbergmann/phpunit
that referenced
this pull request
Jan 4, 2026
* 11.5: Update test expectation after php/php-src#20629 Update tools
sebastianbergmann
added a commit
to sebastianbergmann/phpunit
that referenced
this pull request
Jan 4, 2026
* 12.5: Update test expectation after php/php-src#20629 Update tools
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Jan 5, 2026
…ages in PHP 8.6 (xabbuh) This PR was merged into the 6.4 branch. Discussion ---------- [HttpClient] fix assertion for updated syntax error messages in PHP 8.6 | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT see php/php-src#20629 Commits ------- 192e32c fix assertion for updated syntax error messages in PHP 8.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pretends to add the location where the error occurs when processing a json string (
json_validate()orjson_decode()). As the message suggests, is the "nearby location", like MySQL does it when there is an error with a SQL string.I tried to achieve this many times in the past, but failed, my previous approaches were .... terrible and error-prone.
Now I used a different approach suggested by @bukka . I hope I get closer to a descent implementation. Did my best on this one.
I tested with JSON string with 1GB long, and values were calculated correctly for rows and columns.
Thanks for reviewing and I hope this helps.
Credits:
Besides some reading about bison, etc. ... @bukka pointed to https://github.com/libjso/jso which basically exposed me how to port its code to the PHP parser.