Skip to content

release-8.5.6: fix Dumpling MySQL 8.4 support wording (#23223)#23355

Open
ti-chi-bot wants to merge 1 commit into
pingcap:masterfrom
ti-chi-bot:cherry-pick-23223-to-master
Open

release-8.5.6: fix Dumpling MySQL 8.4 support wording (#23223)#23355
ti-chi-bot wants to merge 1 commit into
pingcap:masterfrom
ti-chi-bot:cherry-pick-23223-to-master

Conversation

@ti-chi-bot

@ti-chi-bot ti-chi-bot commented Jul 25, 2026

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #23223

What is changed, added or deleted? (Required)

Fix inaccurate English wording in release-8.5.6.md. Changed "updated MySQL binary log terminology" to "updated MySQL binary log naming" to match the Chinese original "二进制日志命名" (binary log naming).

The inaccurate English wording "terminology" caused the Japanese translation to use "用語" (terminology), which sounds unnatural in Japanese. The Chinese original "命名" (naming) is more specific to binary log naming conventions. This fix will also correct the downstream Japanese translation when the weekly diff translation runs.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Clarified the Dumpling MySQL 8.4 compatibility note to accurately describe updated MySQL binary log naming.

'terminology' was an inaccurate translation of the Chinese original
'二进制日志命名' (binary log naming). Change to 'naming' for accuracy.
@ti-chi-bot ti-chi-bot added lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-master This PR is cherry-picked to master from a source PR. labels Jul 25, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 25, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qiancai for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 829945a3-2157-4a01-ac1c-907d82d4b0f1

📥 Commits

Reviewing files that changed from the base of the PR and between 7c4550d and 4da8667.

📒 Files selected for processing (1)
  • releases/release-8.5.6.md

📝 Walkthrough

Walkthrough

The Dumpling MySQL 8.4 compatibility note in the 8.5.6 release documentation changes “terminology” to “naming” for updated MySQL binary logs, preserving the existing issue reference and attribution.

Changes

Release note update

Layer / File(s) Summary
MySQL compatibility note wording
releases/release-8.5.6.md
Updates the Dumpling MySQL 8.4 export compatibility wording from binary log “terminology” to “naming.”

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and matches the main change: a wording fix for Dumpling MySQL 8.4 support in release-8.5.6.
Description check ✅ Passed The description includes the required change summary, affected version, and related PR link, and is mostly complete.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-master This PR is cherry-picked to master from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants