release-8.5.6: fix Dumpling MySQL 8.4 support wording (#23223)#23355
release-8.5.6: fix Dumpling MySQL 8.4 support wording (#23223)#23355ti-chi-bot wants to merge 1 commit into
Conversation
'terminology' was an inaccurate translation of the Chinese original '二进制日志命名' (binary log naming). Change to 'naming' for accuracy.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Dumpling MySQL 8.4 compatibility note in the 8.5.6 release documentation changes “terminology” to “naming” for updated MySQL binary logs, preserving the existing issue reference and attribution. ChangesRelease note update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This is an automated cherry-pick of #23223
What is changed, added or deleted? (Required)
Fix inaccurate English wording in release-8.5.6.md. Changed "updated MySQL binary log terminology" to "updated MySQL binary log naming" to match the Chinese original "二进制日志命名" (binary log naming).
The inaccurate English wording "terminology" caused the Japanese translation to use "用語" (terminology), which sounds unnatural in Japanese. The Chinese original "命名" (naming) is more specific to binary log naming conventions. This fix will also correct the downstream Japanese translation when the weekly diff translation runs.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?
Summary by CodeRabbit