reduce repetition by adding keychain functions to config struct#6
Closed
reduce repetition by adding keychain functions to config struct#6
Conversation
|
I dislike having the Config object not be a 1:1 mapping of the TOML and prefer the explicit fetch of sensitive data being clear. Though am not opposed to cleaning up the codebase in general, it's messy because I am over 40 and not OCD about code cleanliness anymore lol |
Author
|
Yes, it's all a matter of taste. In general, I like to implement actions as methods on their data, which is what this does. Still, perfectly easy and far from unheard of to have non-method functions. There's always the option of using a struct other than config to hold the in-memory representation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matter of taste. discard if not wanted.