Skip to content

Commit de4f21b

Browse files
authored
Merge pull request #5694 from plotly/fix-jupyter-deps-issue
[CHORE]: Fix jupyter deps issue
2 parents 33892af + 7719805 commit de4f21b

13 files changed

Lines changed: 4602 additions & 1106 deletions

‎.github/workflows/check-js-build.yml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,9 @@ jobs:
4949
run: |
5050
uv venv
5151
source .venv/bin/activate
52-
uv pip install jupyterlab
52+
# Technically, we only need the `jupyter-builder` package, but using the dev_build extra
53+
# keeps build behavior consistent across all CI jobs
54+
uv sync --extra dev_build
5355
cd js
5456
npm ci
5557
npm run build

‎CONTRIBUTING.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ Two kinds of Jupyter support are included:
251251
which allows us to avoid embedding `plotly.js` in the notebook output.
252252
The JupyterLab extension source code is located at `js/src/mimeExtension.ts`
253253
and the compiled extension code is located at `plotly/labextension` in the built Python package.
254-
The command `jupyter labextension build` (which is one of the steps called by `npm run build`) compiles the extension
254+
The command `jupyter-builder build` (which is one of the steps called by `npm run build`) compiles the extension
255255
and places the build artifacts in `plotly/labextension`.
256256

257257
2. **FigureWidget**:

0 commit comments

Comments
 (0)