Topic
I was checking the CI workflows to understand how linting works. It seems we have https://github.com/processing/p5.js/blob/02475938bb2c7d27eb2680bd8067a0f14eb15a5b/.github/workflows/ci-lint.yml and it wraps lint from package.json:
While checking the logs, I realized that the pipeline almost never fails. https://github.com/processing/p5.js/actions/runs/31380223421 for example, the page shows multiple warnings but because the overall status is "passed", I don't think there is no communication of these issues on commit / PR checks:
Running yarn run lint locally results with
Found 143 warnings and 0 errors.
`yarn run lint --fix:
Found 137 warnings and 0 errors.
yarn lint --fix-suggestions:
Found 93 warnings and 0 errors.
and with yarn lint --fix-dangerously:
Found 45 warnings and 0 errors
My question is, is this something we are aware of? It seems the workflow is hiding the new issues.
After cleaning the existing issues and configuring CI to fail loudly for new issues, a follow up would be moving the lint checks to git hooks so they can run automatically during contribution.
Topic
I was checking the CI workflows to understand how linting works. It seems we have https://github.com/processing/p5.js/blob/02475938bb2c7d27eb2680bd8067a0f14eb15a5b/.github/workflows/ci-lint.yml and it wraps
lintfrompackage.json:p5.js/package.json
Line 14 in 0247593
While checking the logs, I realized that the pipeline almost never fails. https://github.com/processing/p5.js/actions/runs/31380223421 for example, the page shows multiple warnings but because the overall status is "passed", I don't think there is no communication of these issues on commit / PR checks:
Running
yarn run lintlocally results with`yarn run lint --fix:
yarn lint --fix-suggestions:and with
yarn lint --fix-dangerously:My question is, is this something we are aware of? It seems the workflow is hiding the new issues.
After cleaning the existing issues and configuring CI to fail loudly for new issues, a follow up would be moving the lint checks to git hooks so they can run automatically during contribution.