From b9ade11914111e64b97e54c7773d208de94a2bd7 Mon Sep 17 00:00:00 2001 From: Shanmukh Pawan Date: Mon, 27 Jul 2026 13:58:45 -0400 Subject: [PATCH] refactor(build_environment): use `self.run()` in `_createenv()` `_createenv()` called `external_commands.run()` directly while every other method uses `self.run()`, duplicating ctx-access logic for `network_isolation`. The `--python` CLI flag passed to `uv venv` takes precedence over `UV_PYTHON` set by `get_venv_environ()`, so the swap is safe. Closes: #1276 Co-Authored-By: Claude Signed-off-by: Shanmukh Pawan --- src/fromager/build_environment.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/fromager/build_environment.py b/src/fromager/build_environment.py index 1be2fe5b..efe7b1a6 100644 --- a/src/fromager/build_environment.py +++ b/src/fromager/build_environment.py @@ -206,10 +206,7 @@ def _createenv(self) -> None: "--no-project", str(self.path), ] - external_commands.run( - cmd, - network_isolation=self._ctx.network_isolation, - ) + self.run(cmd) logger.info("created build environment in %s", self.path) def install(self, reqs: typing.Iterable[Requirement]) -> None: