Skip to content

TCP Client swallows errors #2

Description

@ProTip

Unfortunately this little bit here makes the client unusable for me as-is:
https://github.com/ragnard/Graphite.NET/blob/master/Graphite/GraphiteTcpClient.cs#L36-L39

I would recommend removing the entire try/catch and let the consumer deal with errors as a quick fix. I have done this and I just throw away the client and create a new one if an error comes up(disconnected tcp client, unable to connect, etc).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions