Commit 2fb4f13
Fix debugOptimized DevSettingsActivity manifest (#57406)
Summary:
Fixes #57396.
`debugOptimized` builds still expose the React Native Dev Menu `Settings` item, but `DevSettingsActivity` was only declared in the `debug` manifest. This caused `Settings` to crash in `debugOptimized` with `ActivityNotFoundException`.
This adds a `debugOptimized` manifest matching the existing debug dev-support manifest, so `DevSettingsActivity` is declared for that build type.
## Changelog:
<!-- Help reviewers and the release process by writing your own changelog entry.
Pick one each for the category and type tags:
[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
[ANDROID] [FIXED] - Fix Dev Menu Settings crash in debugOptimized builds
Pull Request resolved: #57406
Test Plan:
Verified with RNTester debugOptimized:
``` sh
yarn install --frozen-lockfile
yarn start
./gradlew :packages:rn-tester:android:app:installDebugOptimized -PreactNativeArchitectures=arm64-v8a
```
then shake and tap `Settings`, confirm that Debug Settings opens instead of crashing.
Reviewed By: javache
Differential Revision: D110463462
Pulled By: cortinico
fbshipit-source-id: 262a23a70c89bfc2de3d5b211672920be6ddcd2d1 parent 6b45e57 commit 2fb4f13
1 file changed
Lines changed: 22 additions & 0 deletions
Lines changed: 22 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
0 commit comments