From f31612c0888fbd2a5816532141acca2ec10b90ff Mon Sep 17 00:00:00 2001 From: TomasVotruba Date: Wed, 6 May 2026 18:39:32 +0000 Subject: [PATCH 1/2] [automated] Update Rector Dependencies --- composer.lock | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/composer.lock b/composer.lock index 657d41d6..08946bb3 100644 --- a/composer.lock +++ b/composer.lock @@ -3518,12 +3518,12 @@ "source": { "type": "git", "url": "https://github.com/rectorphp/rector.git", - "reference": "313e7155e985b5a3352106091c66347775ff42dc" + "reference": "0f3412868a0c146dcd99ed14535ba95129d39228" }, "dist": { "type": "zip", - "url": "https://api.github.com/repos/rectorphp/rector/zipball/313e7155e985b5a3352106091c66347775ff42dc", - "reference": "313e7155e985b5a3352106091c66347775ff42dc", + "url": "https://api.github.com/repos/rectorphp/rector/zipball/0f3412868a0c146dcd99ed14535ba95129d39228", + "reference": "0f3412868a0c146dcd99ed14535ba95129d39228", "shasum": "" }, "require": { @@ -3571,7 +3571,7 @@ "type": "github" } ], - "time": "2026-05-04T16:46:15+00:00" + "time": "2026-05-06T14:58:49+00:00" }, { "name": "samsonasik/array-lookup", From dc92920793a8ba85dd4c0818f37891ae5c6c8a96 Mon Sep 17 00:00:00 2001 From: GitHub Action Date: Wed, 6 May 2026 18:40:10 +0000 Subject: [PATCH 2/2] [rector] Rector fixes --- src/Controller/FallbackController.php | 2 ++ src/Sets/RectorSetsTreeProvider.php | 2 +- tests/Controller/FallbackControllerTest.php | 16 +++++++++------- tests/Controller/RuleDetailControllerTest.php | 16 +++++++++------- 4 files changed, 21 insertions(+), 15 deletions(-) diff --git a/src/Controller/FallbackController.php b/src/Controller/FallbackController.php index 8ca1e5a0..8cac0462 100644 --- a/src/Controller/FallbackController.php +++ b/src/Controller/FallbackController.php @@ -1,5 +1,7 @@ resolveFromFilePathIncludingConfiguration($set->getSetFilePath()), - static fn ($rectorClass) => is_string($rectorClass), + is_string(...), ); if ($rectorClasses !== []) { $rectorSets[] = new RectorSet($set->getGroupName(), $set->getName(), $rectorClasses); diff --git a/tests/Controller/FallbackControllerTest.php b/tests/Controller/FallbackControllerTest.php index d4a73d97..639bed5f 100644 --- a/tests/Controller/FallbackControllerTest.php +++ b/tests/Controller/FallbackControllerTest.php @@ -1,30 +1,32 @@ get('/simplify-array-search-rector'); + $testResponse = $this->get('/simplify-array-search-rector'); - $response->assertRedirect('/rule-detail/simplify-array-search-rector'); + $testResponse->assertRedirect('/rule-detail/simplify-array-search-rector'); } public function testReturns404ForUnknownSlug(): void { - $response = $this->get('/unknown-rule'); + $testResponse = $this->get('/unknown-rule'); - $response->assertNotFound(); + $testResponse->assertNotFound(); } public function testRedirectsWithPascalCaseSlug(): void { - $response = $this->get('/SimplifyArraySearchRector'); + $testResponse = $this->get('/SimplifyArraySearchRector'); - $response->assertRedirect('/rule-detail/simplify-array-search-rector'); + $testResponse->assertRedirect('/rule-detail/simplify-array-search-rector'); } } diff --git a/tests/Controller/RuleDetailControllerTest.php b/tests/Controller/RuleDetailControllerTest.php index 9aff32e3..c62bf4f4 100644 --- a/tests/Controller/RuleDetailControllerTest.php +++ b/tests/Controller/RuleDetailControllerTest.php @@ -1,5 +1,7 @@ get('/rule-detail/simplify-array-search-rector'); + $testResponse = $this->get('/rule-detail/simplify-array-search-rector'); - $response + $testResponse ->assertOk() ->assertViewIs('homepage.rule_detail') ->assertViewHas('ruleMetadata') @@ -24,15 +26,15 @@ public function testItRendersRulesBySlug(): void public function testItRedirectsToFindRuleIfRuleNotFound(): void { - $response = $this->get('/rule-detail/unknown-rule'); + $testResponse = $this->get('/rule-detail/unknown-rule'); - $response->assertRedirect('/find-rule'); + $testResponse->assertRedirect('/find-rule'); } public function testItRedirectsToKebabCaseSlugIfPascalCaseSlug(): void { - $response = $this->get('/rule-detail/SimplifyArraySearchRector'); + $testResponse = $this->get('/rule-detail/SimplifyArraySearchRector'); - $response->assertRedirect('/rule-detail/simplify-array-search-rector'); + $testResponse->assertRedirect('/rule-detail/simplify-array-search-rector'); } }