test: materialize parametrize argvalues to silence a pytest deprecation

The language server part tests passed their parametrization helpers
straight into @pytest.mark.parametrize as generators. Newer pytest warns
about this (PytestRemovedIn10Warning: "Passing a non-Collection iterable
to parametrize is deprecated"), because it needs to iterate the values
more than once.

Wrap the generate_tests_from_source_document call sites in list(), and
let the local prepend_protocol_data helper return a list instead of
yielding.

Author: d-biehl

tests/robotcode/language_server/robotframework/parts/test_code_action_show_documentation.py

@@ -28,10 +28,12 @@
 
 @pytest.mark.parametrize(
     ("test_document", "data"),
-    generate_tests_from_source_document(
-        Path(
-            Path(__file__).parent,
-            "data/tests/code_action_show_documentation.robot",
+    list(
+        generate_tests_from_source_document(
+            Path(
+                Path(__file__).parent,
+                "data/tests/code_action_show_documentation.robot",
+            )
         )
     ),
     indirect=["test_document"],

tests/robotcode/language_server/robotframework/parts/test_document_highlight.py

@@ -19,7 +19,7 @@
 
 @pytest.mark.parametrize(
     ("test_document", "data"),
-    generate_tests_from_source_document(Path(Path(__file__).parent, "data/tests/document_highlight.robot")),
+    list(generate_tests_from_source_document(Path(Path(__file__).parent, "data/tests/document_highlight.robot"))),
     indirect=["test_document"],
     ids=generate_test_id,
     scope="module",

tests/robotcode/language_server/robotframework/parts/test_document_symbols.py

@@ -47,7 +47,7 @@ def split(
 
 @pytest.mark.parametrize(
     ("test_document", "data"),
-    generate_tests_from_source_document(Path(Path(__file__).parent, "data/tests/symbols.robot")),
+    list(generate_tests_from_source_document(Path(Path(__file__).parent, "data/tests/symbols.robot"))),
     indirect=["test_document"],
     ids=generate_test_id,
     scope="module",

tests/robotcode/language_server/robotframework/parts/test_foldingrange.py

@@ -1,5 +1,5 @@
 from pathlib import Path
-from typing import Any, Iterable, Iterator, Tuple, Union
+from typing import Any, Iterable, List, Tuple, Union
 
 import pytest
 import yaml
@@ -25,10 +25,8 @@
 def prepend_protocol_data(
     protocol: Iterable[Any],
     data: Iterable[Union[Tuple[Any, Path, GeneratedTestData], Any]],
-) -> Iterator[Union[Tuple[Any, Path, GeneratedTestData], Any]]:
-    for p in protocol:
-        for d in data:
-            yield (p, *d)
+) -> List[Union[Tuple[Any, Path, GeneratedTestData], Any]]:
+    return [(p, *d) for p in protocol for d in data]
 
 
 def generate_foldingrange_test_id(params: Any) -> Any:

tests/robotcode/language_server/robotframework/parts/test_goto_definition.py

@@ -20,7 +20,7 @@
 
 @pytest.mark.parametrize(
     ("test_document", "data"),
-    generate_tests_from_source_document(Path(Path(__file__).parent, "data/tests/goto.robot")),
+    list(generate_tests_from_source_document(Path(Path(__file__).parent, "data/tests/goto.robot"))),
     indirect=["test_document"],
     ids=generate_test_id,
     scope="module",

tests/robotcode/language_server/robotframework/parts/test_goto_implementation.py

@@ -44,7 +44,7 @@ def split(
 
 @pytest.mark.parametrize(
     ("test_document", "data"),
-    generate_tests_from_source_document(Path(Path(__file__).parent, "data/tests/goto.robot")),
+    list(generate_tests_from_source_document(Path(Path(__file__).parent, "data/tests/goto.robot"))),
     indirect=["test_document"],
     ids=generate_test_id,
     scope="module",

tests/robotcode/language_server/robotframework/parts/test_hover.py

@@ -41,7 +41,7 @@ def split(hover: Optional[Hover]) -> Optional[Hover]:
 
 @pytest.mark.parametrize(
     ("test_document", "data"),
-    generate_tests_from_source_document(Path(Path(__file__).parent, "data/tests/hover.robot")),
+    list(generate_tests_from_source_document(Path(Path(__file__).parent, "data/tests/hover.robot"))),
     indirect=["test_document"],
     ids=generate_test_id,
     scope="module",

tests/robotcode/language_server/robotframework/parts/test_references.py

@@ -19,7 +19,7 @@
 
 @pytest.mark.parametrize(
     ("test_document", "data"),
-    generate_tests_from_source_document(Path(Path(__file__).parent, "data/tests/references.robot")),
+    list(generate_tests_from_source_document(Path(Path(__file__).parent, "data/tests/references.robot"))),
     indirect=["test_document"],
     ids=generate_test_id,
     scope="module",

tests/robotcode/language_server/robotframework/parts/test_signature_help.py

@@ -24,7 +24,7 @@
 
 @pytest.mark.parametrize(
     ("test_document", "data"),
-    generate_tests_from_source_document(Path(Path(__file__).parent, "data/tests/signature_help.robot")),
+    list(generate_tests_from_source_document(Path(Path(__file__).parent, "data/tests/signature_help.robot"))),
     indirect=["test_document"],
     ids=generate_test_id,
     scope="module",