Security: Missing resource-level authorization on build retrieval endpoint (potential IDOR/data leak)#3484
Open
tomaioo wants to merge 1 commit into
Conversation
The `GET /builds/{id}` handler returns build data (including environment and step details) without checking whether the caller can access the associated pipeline/build. This can allow authenticated users to enumerate and read build records outside their authorization boundary.
Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
|
coverage: 95.276% (-0.1%) from 95.4% — tomaioo:fix/security/missing-resource-level-authorization-on- into screwdriver-cd:master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Missing resource-level authorization on build retrieval endpoint (potential IDOR/data leak)
Problem
Severity:
High| File:plugins/builds/get.js:L23The
GET /builds/{id}handler returns build data (including environment and step details) without checking whether the caller can access the associated pipeline/build. This can allow authenticated users to enumerate and read build records outside their authorization boundary.Solution
Before returning build data, enforce access checks against the build's pipeline/event ownership using credential-aware authorization helpers. Deny access when the token does not match the target resource.
Changes
plugins/builds/get.js(modified)