fix(tables): reject rolled-over TTL dates

Author: j15z

apps/sim/lib/table/__tests__/column-type-registry.test.ts

@@ -145,6 +145,26 @@ describe('ttl columns', () => {
     expect(COLUMN_TYPE_REGISTRY.ttl.coerce(1_700_000_000.5, column)).toEqual({ ok: false })
   })
 
+  it.each(['2023-02-29', '2023-02-29T12:00:00', '2023-02-29T12:00:00-05:00'])(
+    'rejects a nonexistent ISO calendar input: %s',
+    (value) => {
+      expect(COLUMN_TYPE_REGISTRY.ttl.coerce(value, column, { timezone: 'UTC' })).toEqual({
+        ok: false,
+      })
+    }
+  )
+
+  it.each([
+    ['2024-02-29', '2024-02-29T00:00:00Z'],
+    ['2024-02-29T12:00:00', '2024-02-29T12:00:00Z'],
+    ['2024-02-29T12:00:00-05:00', '2024-02-29T17:00:00Z'],
+  ])('accepts a valid leap-day ISO calendar input: %s', (value, expectedInstant) => {
+    expect(COLUMN_TYPE_REGISTRY.ttl.coerce(value, column, { timezone: 'UTC' })).toEqual({
+      ok: true,
+      value: Math.floor(Date.parse(expectedInstant) / 1000),
+    })
+  })
+
   it('renders and edits epoch seconds as a date', () => {
     expect(COLUMN_TYPE_REGISTRY.ttl.formatForDisplay(1_700_000_000, column)).toBe(
       '11/14/2023 10:13:20 PM'

apps/sim/lib/table/column-types/ttl.ts

@@ -9,7 +9,7 @@ import {
 import type { ColumnDefinition } from '@/lib/table/types'
 
 const NUMERIC_VALUE_PATTERN = /^-?\d+(?:\.\d+)?$/
-const EXPLICIT_OFFSET_PATTERN = /(?:Z|[+-]\d{2}:?\d{2})$/i
+const ISO_DATE_PREFIX_PATTERN = /^(\d{4}-\d{2}-\d{2})(?:$|[T ])/i
 
 function isRepresentableEpochSeconds(value: number): boolean {
   return Number.isSafeInteger(value) && !Number.isNaN(new Date(value * 1000).getTime())
@@ -36,19 +36,14 @@ export function parseTtlEpochSeconds(
     return isRepresentableEpochSeconds(numeric) ? numeric : null
   }
 
-  if (EXPLICIT_OFFSET_PATTERN.test(trimmed)) {
-    const milliseconds = Date.parse(trimmed)
-    if (Number.isNaN(milliseconds)) return null
-    const seconds = Math.floor(milliseconds / 1000)
-    return isRepresentableEpochSeconds(seconds) ? seconds : null
-  }
-
   const normalized = normalizeDateCellValue(trimmed, options)
   if (normalized === null) return null
   const instant = /^\d{4}-\d{2}-\d{2}$/.test(normalized)
     ? normalizeDateCellValue(`${normalized}T00:00:00`, options)
     : normalized
   if (instant === null) return null
+  const inputIsoDate = trimmed.match(ISO_DATE_PREFIX_PATTERN)?.[1]
+  if (inputIsoDate && instant.slice(0, 10) !== inputIsoDate) return null
   const milliseconds = Date.parse(instant)
   if (Number.isNaN(milliseconds)) return null
   const seconds = Math.floor(milliseconds / 1000)