fix(webhooks): restore NEXT_PUBLIC_APP_URL in emailbison tests, dedupe strict-delete warning log

Test env var mutation was never restored, risking cross-file leakage in
single-threaded vitest runs. Strict-mode deleteSubscription failures were
logged twice (once at the throw site with context, once generically by the
outer catch); the outer catch now skips its own log for errors already
logged at the throw site.

Author: waleedlatif1

apps/sim/lib/webhooks/providers/emailbison.test.ts

@@ -2,7 +2,7 @@
  * @vitest-environment node
  */
 import { inputValidationMock, inputValidationMockFns } from '@sim/testing'
-import { beforeEach, describe, expect, it, vi } from 'vitest'
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
 
 vi.mock('@/lib/core/security/input-validation.server', () => inputValidationMock)
 
@@ -38,6 +38,10 @@ describe('emailBisonHandler createSubscription', () => {
     process.env.NEXT_PUBLIC_APP_URL = 'https://app.example.com'
   })
 
+  afterEach(() => {
+    process.env.NEXT_PUBLIC_APP_URL = undefined
+  })
+
   it('rejects an apiBaseUrl that resolves to a blocked address before making a request', async () => {
     inputValidationMockFns.mockValidateUrlWithDNS.mockResolvedValue({
       isValid: false,

apps/sim/lib/webhooks/providers/emailbison.ts

@@ -219,7 +219,8 @@ export const emailBisonHandler: WebhookProviderHandler = {
           hasApiBaseUrl: Boolean(apiBaseUrl),
           hasExternalId: Boolean(externalId),
         })
-        if (ctx.strict) throw new Error('Missing Email Bison webhook cleanup configuration')
+        if (ctx.strict)
+          throw new AlreadyLoggedError('Missing Email Bison webhook cleanup configuration')
         return
       }
 
@@ -233,7 +234,8 @@ export const emailBisonHandler: WebhookProviderHandler = {
         logger.warn(`[${requestId}] Invalid Email Bison Instance URL: ${urlValidation.error}`, {
           webhookId: webhook.id,
         })
-        if (ctx.strict) throw new Error('Email Bison Instance URL could not be validated.')
+        if (ctx.strict)
+          throw new AlreadyLoggedError('Email Bison Instance URL could not be validated.')
         return
       }
 
@@ -248,7 +250,8 @@ export const emailBisonHandler: WebhookProviderHandler = {
           status: response.status,
           response: responseBody,
         })
-        if (ctx.strict) throw new Error(`Failed to delete Email Bison webhook: ${response.status}`)
+        if (ctx.strict)
+          throw new AlreadyLoggedError(`Failed to delete Email Bison webhook: ${response.status}`)
         return
       }
 
@@ -258,14 +261,23 @@ export const emailBisonHandler: WebhookProviderHandler = {
         webhookId: webhook.id,
       })
     } catch (error) {
-      logger.warn(`[${requestId}] Error deleting Email Bison webhook`, {
-        message: toError(error).message,
-      })
+      if (!(error instanceof AlreadyLoggedError)) {
+        logger.warn(`[${requestId}] Error deleting Email Bison webhook`, {
+          message: toError(error).message,
+        })
+      }
       if (ctx.strict) throw error
     }
   },
 }
 
+/**
+ * Marks an error whose failure reason has already been logged with full context
+ * at the throw site, so the outer catch in `deleteSubscription` does not emit
+ * a second, redundant warning for the same failure.
+ */
+class AlreadyLoggedError extends Error {}
+
 async function parseJsonResponse(
   response: SecureFetchResponse
 ): Promise<Record<string, unknown> | null> {