fix(billing): guard the new subscription-created instrumentation block

Greptile P1: the org-scope check I added for the audit-metadata fix
(isSubscriptionOrgScoped) was a raw DB call with no error guard, unlike
resolveSubscriptionActorId next to it. Since it ran inside the
idempotency lambda with an unconditional rethrow, a transient DB error
would abort and retry the whole webhook after the free -> paid usage
reset had already committed. Wrap the actor/org-scope resolution +
audit + analytics block in try/catch, matching the same guarded
instrumentation pattern already used in handleInvoicePaymentFailed.

Author: waleedlatif1

apps/sim/lib/billing/webhooks/subscription.ts

@@ -285,28 +285,38 @@ export async function handleSubscriptionCreated(
         }
 
         if (wasFreePreviously && isPaidPlan) {
-          const actorId = await resolveSubscriptionActorId(subscriptionData.referenceId)
-          const isOrgScoped = await isSubscriptionOrgScoped({
-            referenceId: subscriptionData.referenceId,
-          })
-          recordAudit({
-            actorId,
-            action: AuditAction.SUBSCRIPTION_CREATED,
-            resourceType: AuditResourceType.SUBSCRIPTION,
-            resourceId: subscriptionData.id,
-            description: `Subscription created on ${subscriptionData.plan ?? 'unknown'} plan for ${subscriptionData.referenceId}`,
-            metadata: {
-              plan: subscriptionData.plan,
+          // Best-effort instrumentation; a transient DB error here must never abort
+          // the (already-committed) free -> paid usage reset above, so it's guarded.
+          try {
+            const actorId = await resolveSubscriptionActorId(subscriptionData.referenceId)
+            const isOrgScoped = await isSubscriptionOrgScoped({
+              referenceId: subscriptionData.referenceId,
+            })
+            recordAudit({
+              actorId,
+              action: AuditAction.SUBSCRIPTION_CREATED,
+              resourceType: AuditResourceType.SUBSCRIPTION,
+              resourceId: subscriptionData.id,
+              description: `Subscription created on ${subscriptionData.plan ?? 'unknown'} plan for ${subscriptionData.referenceId}`,
+              metadata: {
+                plan: subscriptionData.plan,
+                status: subscriptionData.status,
+                referenceId: subscriptionData.referenceId,
+                ...(isOrgScoped ? { organizationId: subscriptionData.referenceId } : {}),
+              },
+            })
+            captureServerEvent(subscriptionData.referenceId, 'subscription_created', {
+              plan: subscriptionData.plan ?? 'unknown',
               status: subscriptionData.status,
+              reference_id: subscriptionData.referenceId,
+            })
+          } catch (instrumentationError) {
+            logger.warn('Failed to record subscription-created instrumentation', {
+              subscriptionId: subscriptionData.id,
               referenceId: subscriptionData.referenceId,
-              ...(isOrgScoped ? { organizationId: subscriptionData.referenceId } : {}),
-            },
-          })
-          captureServerEvent(subscriptionData.referenceId, 'subscription_created', {
-            plan: subscriptionData.plan ?? 'unknown',
-            status: subscriptionData.status,
-            reference_id: subscriptionData.referenceId,
-          })
+              error: instrumentationError,
+            })
+          }
         }
       }
     )