fix(custom-block): bind publish authz to the source workflow's workspace

Author: TheodoreSpeaks

apps/sim/app/api/custom-blocks/route.ts

@@ -111,6 +111,7 @@ export const POST = withRouteHandler(async (request: NextRequest) => {
   try {
     const block = await publishCustomBlock({
       organizationId,
+      workspaceId,
       workflowId,
       userId,
       name,

apps/sim/lib/workflows/custom-blocks/operations.ts

@@ -188,20 +188,33 @@ export class CustomBlockValidationError extends Error {
 }
 
 /**
- * Publish a deployed workflow as an org-wide custom block. Validates that the
- * source workflow belongs to `organizationId` and is deployed, then inserts the
- * row. Caller must have already authorized admin + enterprise.
+ * Publish a deployed workflow as an org-wide custom block. The source workflow
+ * must live in `workspaceId` — the workspace the caller was verified to admin —
+ * so a caller cannot publish another workspace's workflow (which then runs under
+ * that workspace owner's credentials and returns caller-chosen outputs). Also
+ * validates the workspace belongs to `organizationId` and the workflow is
+ * deployed, then inserts the row.
  */
 export async function publishCustomBlock(params: {
   organizationId: string
+  workspaceId: string
   workflowId: string
   userId: string
   name: string
   description: string
   iconUrl?: string
   exposedOutputs?: CustomBlockOutput[]
 }): Promise<CustomBlockWithInputs> {
-  const { organizationId, workflowId, userId, name, description, iconUrl, exposedOutputs } = params
+  const {
+    organizationId,
+    workspaceId,
+    workflowId,
+    userId,
+    name,
+    description,
+    iconUrl,
+    exposedOutputs,
+  } = params
 
   const [wf] = await db
     .select({ id: workflow.id, workspaceId: workflow.workspaceId, isDeployed: workflow.isDeployed })
@@ -214,6 +227,13 @@ export async function publishCustomBlock(params: {
     throw new CustomBlockValidationError('Workflow must be deployed before publishing as a block')
   }
 
+  // Authorization boundary: the caller proved admin on `workspaceId` (route), so
+  // the source workflow must actually live there. Without this a workspace admin
+  // could publish a different workspace's workflow in the same org.
+  if (wf.workspaceId !== workspaceId) {
+    throw new CustomBlockValidationError('You can only publish a workflow from its own workspace')
+  }
+
   const ws = wf.workspaceId ? await getWorkspaceWithOwner(wf.workspaceId) : null
   if (!ws?.organizationId || ws.organizationId !== organizationId) {
     throw new CustomBlockValidationError('Workflow does not belong to this organization')