Skip to content

Commit ee9812c

Browse files
committed
fix(secrets): guard active-tab re-click, restore keepPreviousData on workspace env query
1 parent 263744d commit ee9812c

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/settings-sidebar/settings-sidebar.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -324,6 +324,7 @@ export function SettingsSidebar({
324324
onFocus={() => handlePrefetch(item.id)}
325325
onClick={() => {
326326
const section = item.id as SettingsSection
327+
if (section === activeSection) return
327328
if (!requestNavigation(section)) {
328329
setShowDiscardDialog(true)
329330
return

apps/sim/hooks/queries/environment.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { createLogger } from '@sim/logger'
2-
import { useMutation, useQuery, useQueryClient } from '@tanstack/react-query'
2+
import { keepPreviousData, useMutation, useQuery, useQueryClient } from '@tanstack/react-query'
33
import type { EnvironmentVariable, WorkspaceEnvironmentData } from '@/lib/environment/api'
44
import { fetchPersonalEnvironment, fetchWorkspaceEnvironment } from '@/lib/environment/api'
55
import { workspaceCredentialKeys } from '@/hooks/queries/credentials'
@@ -39,6 +39,7 @@ export function useWorkspaceEnvironment<TData = WorkspaceEnvironmentData>(
3939
queryFn: ({ signal }) => fetchWorkspaceEnvironment(workspaceId, signal),
4040
enabled: !!workspaceId,
4141
staleTime: 60 * 1000, // 1 minute
42+
placeholderData: keepPreviousData,
4243
...options,
4344
})
4445
}

0 commit comments

Comments
 (0)