fix(uploads): share MAX_MULTIPART_OVERHEAD_BYTES constant across upload routes

Author: waleedlatif1

apps/sim/app/api/files/upload/route.ts

@@ -13,6 +13,7 @@ import { getSession } from '@/lib/auth'
 import {
   assertKnownSizeWithinLimit,
   isPayloadSizeLimitError,
+  MAX_MULTIPART_OVERHEAD_BYTES,
   readFileToBufferWithLimit,
   readFormDataWithLimit,
 } from '@/lib/core/utils/stream-limits'
@@ -32,7 +33,6 @@ import { getUserEntityPermissions } from '@/lib/workspaces/permissions/utils'
 import { createErrorResponse, InvalidRequestError } from '@/app/api/files/utils'
 
 const ALLOWED_EXTENSIONS = new Set<string>(SUPPORTED_ATTACHMENT_EXTENSIONS)
-const MAX_MULTIPART_OVERHEAD_BYTES = 1024 * 1024
 
 function validateFileExtension(filename: string): boolean {
   const extension = filename.split('.').pop()?.toLowerCase()

apps/sim/app/api/v1/files/route.ts

@@ -7,6 +7,7 @@ import { getValidationErrorMessage, parseRequest } from '@/lib/api/server'
 import { generateRequestId } from '@/lib/core/utils/request'
 import {
   isPayloadSizeLimitError,
+  MAX_MULTIPART_OVERHEAD_BYTES,
   readFileToBufferWithLimit,
   readFormDataWithLimit,
 } from '@/lib/core/utils/stream-limits'
@@ -30,7 +31,6 @@ export const dynamic = 'force-dynamic'
 export const revalidate = 0
 
 const MAX_FILE_SIZE = 100 * 1024 * 1024
-const MAX_MULTIPART_OVERHEAD_BYTES = 1024 * 1024
 
 /** GET /api/v1/files — List all files in a workspace. */
 export const GET = withRouteHandler(async (request: NextRequest) => {

apps/sim/app/api/v1/knowledge/[id]/documents/route.ts

@@ -6,7 +6,11 @@ import {
 } from '@/lib/api/contracts/v1/knowledge'
 import { parseRequest } from '@/lib/api/server'
 import { checkActorUsageLimits } from '@/lib/billing/calculations/usage-monitor'
-import { isPayloadSizeLimitError, readFormDataWithLimit } from '@/lib/core/utils/stream-limits'
+import {
+  isPayloadSizeLimitError,
+  MAX_MULTIPART_OVERHEAD_BYTES,
+  readFormDataWithLimit,
+} from '@/lib/core/utils/stream-limits'
 import { withRouteHandler } from '@/lib/core/utils/with-route-handler'
 import {
   createSingleDocument,
@@ -24,7 +28,6 @@ export const dynamic = 'force-dynamic'
 export const revalidate = 0
 
 const MAX_FILE_SIZE = 100 * 1024 * 1024 // 100MB
-const MAX_MULTIPART_OVERHEAD_BYTES = 1024 * 1024
 
 interface DocumentsRouteParams {
   params: Promise<{ id: string }>

apps/sim/app/api/workspaces/[id]/files/route.ts

@@ -9,7 +9,11 @@ import {
 import { getValidationErrorMessage } from '@/lib/api/server'
 import { getSession } from '@/lib/auth'
 import { generateRequestId } from '@/lib/core/utils/request'
-import { isPayloadSizeLimitError, readFormDataWithLimit } from '@/lib/core/utils/stream-limits'
+import {
+  isPayloadSizeLimitError,
+  MAX_MULTIPART_OVERHEAD_BYTES,
+  readFormDataWithLimit,
+} from '@/lib/core/utils/stream-limits'
 import { withRouteHandler } from '@/lib/core/utils/with-route-handler'
 import { captureServerEvent } from '@/lib/posthog/server'
 import { getSharesForResources } from '@/lib/public-shares/share-manager'
@@ -25,7 +29,6 @@ import { verifyWorkspaceMembership } from '@/app/api/workflows/utils'
 export const dynamic = 'force-dynamic'
 
 const logger = createLogger('WorkspaceFilesAPI')
-const MAX_MULTIPART_OVERHEAD_BYTES = 1024 * 1024
 
 /**
  * GET /api/workspaces/[id]/files

apps/sim/lib/core/utils/stream-limits.ts

@@ -2,6 +2,13 @@ import { toError } from '@sim/utils/errors'
 
 export const DEFAULT_MAX_ERROR_BODY_BYTES = 64 * 1024
 
+/**
+ * Slack for multipart boundary/header overhead on top of the intended file
+ * size limit, so legitimate uploads near the limit aren't rejected purely
+ * for encoding overhead.
+ */
+export const MAX_MULTIPART_OVERHEAD_BYTES = 1024 * 1024
+
 export interface PayloadSizeLimitContext {
   label: string
   maxBytes: number