4.8.2 seems to be able to cause ERR_SERVER_NOT_RUNNING

[rbargholz]

Describe the bug
When running Angular tests with Karma, this library can now double close a Node server on 4.8.2 leading to .ERR_SERVER_NOT_RUNNING. I believe this issue was mentioned as being known about and that they would handle it in v5 in #4546 however 4.8.2 and #5344 seem to have caused the issue prematurely.

I was able to work around this issue by pinning Karma's metadependency. This appeared to fix the issue.

"overrides": {
    "karma": {
        "socket.io": "4.8.1"
    }
}

I believe this is now a bug with socket.io integrating with other libraries.

To Reproduce
Starting tests in an Angular application and then closing the server causes ERR_SERVER_NOT_RUNNING.

Expected behavior
I expect socket.io to not close a closed HTTP server.

[davysteegen]

We started to notice the same problem today with our existing builds that run Karma tests for Angular modules. The temporary workaround provided by @rbargholz fixed the problem!

[darrachequesne]

The failing commit seems to be: bb0b480

From karma source code: https://github.com/karma-runner/karma/blob/84f85e7016efc2266fa6b3465f494a3fa151c85c/lib/server.js#L453-L477

    this.emitExitAsync(exitCode).catch((err) => {
      this.log.error('Error while calling exit event listeners\n' + err.stack || err)
      return 1
    }).then((code) => {
      socketServer.sockets.removeAllListeners()
      socketServer.close() // close the socket.io server


      let removeAllListenersDone = false
      const removeAllListeners = () => {
        if (removeAllListenersDone) {
          return
        }
        removeAllListenersDone = true
        webServer.removeAllListeners()
        processWrapper.removeAllListeners()
        done(code || 0)
      }


      const closeTimeout = setTimeout(removeAllListeners, webServerCloseTimeout)


      webServer.close(() => { // and then the Node.js HTTP server
        clearTimeout(closeTimeout)
        removeAllListeners()
      })
    })

I think I understand. Previously, webServer.close() would return an error which was silently ignored (because socketServer.close() would already close the HTTP server, see #4546). But due to the commit and the awaited Promise, webServer.close() is now called first and then socketServer.close() throws an exception.

[darrachequesne]

We have published a quickfix: 9581f9b

Released as socket.io@4.8.3. Could you please check?

[davysteegen]

@darrachequesne
I can confirm that for me the issue is resolved! Thank you for the quick action 🙌

[kbourzayq]

Thanks!
Everything is running fine

[rbargholz]

@darrachequesne Thank you! Everything works well on our end as well.