lint

Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>

Author: jerm-dro

cmd/thv-operator/controllers/mcpserver_controller.go

@@ -23,7 +23,7 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/apimachinery/pkg/util/intstr"
-	"k8s.io/client-go/tools/record"
+	"k8s.io/client-go/tools/events"
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
@@ -43,7 +43,7 @@ import (
 type MCPServerReconciler struct {
 	client.Client
 	Scheme           *runtime.Scheme
-	Recorder         record.EventRecorder
+	Recorder         events.EventRecorder
 	PlatformDetector *ctrlutil.SharedPlatformDetector
 	ImageValidation  validation.ImageValidation
 }
@@ -509,7 +509,7 @@ func (r *MCPServerReconciler) validateAndUpdatePodTemplateStatus(ctx context.Con
 	if err != nil {
 		// Record event for invalid PodTemplateSpec
 		if r.Recorder != nil {
-			r.Recorder.Eventf(mcpServer, corev1.EventTypeWarning, "InvalidPodTemplateSpec",
+			r.Recorder.Eventf(mcpServer, nil, corev1.EventTypeWarning, "InvalidPodTemplateSpec", "Validate",
 				"Failed to parse PodTemplateSpec: %v. Deployment blocked until PodTemplateSpec is fixed.", err)
 		}
 

cmd/thv-operator/controllers/mcpserver_invalid_podtemplate_reconcile_test.go

@@ -11,7 +11,7 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/client-go/kubernetes/scheme"
-	"k8s.io/client-go/tools/record"
+	"k8s.io/client-go/tools/events"
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/client/fake"
@@ -103,8 +103,8 @@ func TestMCPServerReconciler_InvalidPodTemplateSpec(t *testing.T) {
 			require.NoError(t, scheme.AddToScheme(s))
 			require.NoError(t, mcpv1alpha1.AddToScheme(s))
 
-			// Create a fake event recorder for each test
-			eventRecorder := record.NewFakeRecorder(10)
+			// Create a fake event recorder
+			eventRecorder := events.NewFakeRecorder(10)
 
 			// Create a fake client with the MCPServer
 			fakeClient := fake.NewClientBuilder().
@@ -208,7 +208,7 @@ func TestDeploymentArgsWithInvalidPodTemplateSpec(t *testing.T) {
 	r := &MCPServerReconciler{
 		Client:           fakeClient,
 		Scheme:           s,
-		Recorder:         record.NewFakeRecorder(10),
+		Recorder:         events.NewFakeRecorder(10),
 		PlatformDetector: ctrlutil.NewSharedPlatformDetector(),
 	}
 

cmd/thv-operator/controllers/virtualmcpserver_controller.go

@@ -18,7 +18,7 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/types"
-	"k8s.io/client-go/tools/record"
+	"k8s.io/client-go/tools/events"
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/handler"
@@ -61,7 +61,7 @@ const (
 type VirtualMCPServerReconciler struct {
 	client.Client
 	Scheme           *runtime.Scheme
-	Recorder         record.EventRecorder
+	Recorder         events.EventRecorder
 	PlatformDetector *ctrlutil.SharedPlatformDetector
 }
 
@@ -389,7 +389,7 @@ func (r *VirtualMCPServerReconciler) validateAndUpdatePodTemplateStatus(
 	if err != nil {
 		// Record event for invalid PodTemplateSpec
 		if r.Recorder != nil {
-			r.Recorder.Eventf(vmcp, corev1.EventTypeWarning, "InvalidPodTemplateSpec",
+			r.Recorder.Eventf(vmcp, nil, corev1.EventTypeWarning, "InvalidPodTemplateSpec", "Validate",
 				"Failed to parse PodTemplateSpec: %v. Deployment blocked until PodTemplateSpec is fixed.", err)
 		}
 
@@ -441,7 +441,7 @@ func (r *VirtualMCPServerReconciler) ensureAllResources(
 		statusManager.SetObservedGeneration(vmcp.Generation)
 		// Record event for secret validation failure
 		if r.Recorder != nil {
-			r.Recorder.Eventf(vmcp, corev1.EventTypeWarning, "SecretValidationFailed",
+			r.Recorder.Eventf(vmcp, nil, corev1.EventTypeWarning, "SecretValidationFailed", "Validate",
 				"Secret validation failed: %v", err)
 		}
 		return err
@@ -646,14 +646,14 @@ func (r *VirtualMCPServerReconciler) ensureDeployment(
 			ctxLogger.Error(err, "Failed to create new Deployment")
 			// Record event for deployment creation failure
 			if r.Recorder != nil {
-				r.Recorder.Eventf(vmcp, corev1.EventTypeWarning, "DeploymentCreationFailed",
+				r.Recorder.Eventf(vmcp, nil, corev1.EventTypeWarning, "DeploymentCreationFailed", "Create",
 					"Failed to create Deployment: %v", err)
 			}
 			return ctrl.Result{}, err
 		}
 		// Record event for successful deployment creation
 		if r.Recorder != nil {
-			r.Recorder.Event(vmcp, corev1.EventTypeNormal, "DeploymentCreated",
+			r.Recorder.Eventf(vmcp, nil, corev1.EventTypeNormal, "DeploymentCreated", "Create",
 				"Deployment created successfully")
 		}
 		// Return empty result to continue with rest of reconciliation (Service, status update, etc.)
@@ -690,15 +690,15 @@ func (r *VirtualMCPServerReconciler) ensureDeployment(
 			ctxLogger.Error(err, "Failed to update Deployment")
 			// Record event for deployment update failure
 			if r.Recorder != nil {
-				r.Recorder.Eventf(vmcp, corev1.EventTypeWarning, "DeploymentUpdateFailed",
+				r.Recorder.Eventf(vmcp, nil, corev1.EventTypeWarning, "DeploymentUpdateFailed", "Update",
 					"Failed to update Deployment: %v", err)
 			}
 			// Return error to trigger reconcile retry (handles transient failures and conflicts)
 			return ctrl.Result{}, err
 		}
 		// Record event for successful deployment update (config change triggers rollout)
 		if r.Recorder != nil {
-			r.Recorder.Event(vmcp, corev1.EventTypeNormal, "DeploymentUpdated",
+			r.Recorder.Eventf(vmcp, nil, corev1.EventTypeNormal, "DeploymentUpdated", "Update",
 				"Deployment updated, rolling out new configuration")
 		}
 		// Return empty result to continue with rest of reconciliation
@@ -732,14 +732,14 @@ func (r *VirtualMCPServerReconciler) ensureService(
 			ctxLogger.Error(err, "Failed to create new Service")
 			// Record event for service creation failure
 			if r.Recorder != nil {
-				r.Recorder.Eventf(vmcp, corev1.EventTypeWarning, "ServiceCreationFailed",
+				r.Recorder.Eventf(vmcp, nil, corev1.EventTypeWarning, "ServiceCreationFailed", "Create",
 					"Failed to create Service: %v", err)
 			}
 			return ctrl.Result{}, err
 		}
 		// Record event for successful service creation
 		if r.Recorder != nil {
-			r.Recorder.Eventf(vmcp, corev1.EventTypeNormal, "ServiceCreated",
+			r.Recorder.Eventf(vmcp, nil, corev1.EventTypeNormal, "ServiceCreated", "Create",
 				"Service %s created successfully", serviceName)
 		}
 		// Return empty result to continue with rest of reconciliation

cmd/thv-operator/main.go

@@ -249,7 +249,7 @@ func setupServerControllers(mgr ctrl.Manager, enableRegistry bool) error {
 	rec := &controllers.MCPServerReconciler{
 		Client:           mgr.GetClient(),
 		Scheme:           mgr.GetScheme(),
-		Recorder:         mgr.GetEventRecorderFor("mcpserver-controller"),
+		Recorder:         mgr.GetEventRecorder("mcpserver-controller"),
 		PlatformDetector: ctrlutil.NewSharedPlatformDetector(),
 		ImageValidation:  imageValidation,
 	}
@@ -309,7 +309,7 @@ func setupAggregationControllers(mgr ctrl.Manager, enableWebhooks bool) error {
 	if err := (&controllers.VirtualMCPServerReconciler{
 		Client:           mgr.GetClient(),
 		Scheme:           mgr.GetScheme(),
-		Recorder:         mgr.GetEventRecorderFor("virtualmcpserver-controller"),
+		Recorder:         mgr.GetEventRecorder("virtualmcpserver-controller"),
 		PlatformDetector: ctrlutil.NewSharedPlatformDetector(),
 	}).SetupWithManager(mgr); err != nil {
 		return fmt.Errorf("unable to create controller VirtualMCPServer: %w", err)

deploy/charts/operator/README.md

@@ -49,7 +49,7 @@ The command removes all the Kubernetes components associated with the chart and
 ## Values
 
 | Key | Type | Default | Description |
-|-----|------|---------|-------------|
+|-----|-------------|------|---------|
 | fullnameOverride | string | `"toolhive-operator"` | Provide a fully-qualified name override for resources |
 | nameOverride | string | `""` | Override the name of the chart |
 | operator | object | `{"affinity":{},"autoscaling":{"enabled":false,"maxReplicas":100,"minReplicas":1,"targetCPUUtilizationPercentage":80},"containerSecurityContext":{"allowPrivilegeEscalation":false,"capabilities":{"drop":["ALL"]},"readOnlyRootFilesystem":true,"runAsNonRoot":true,"runAsUser":1000,"seccompProfile":{"type":"RuntimeDefault"}},"env":{},"features":{"experimental":false,"registry":true,"server":true,"virtualMCP":true,"webhooks":false},"gc":{"gogc":75,"gomeglimit":"150MiB"},"image":"ghcr.io/stacklok/toolhive/operator:v0.7.2","imagePullPolicy":"IfNotPresent","imagePullSecrets":[],"leaderElectionRole":{"binding":{"name":"toolhive-operator-leader-election-rolebinding"},"name":"toolhive-operator-leader-election-role","rules":[{"apiGroups":[""],"resources":["configmaps"],"verbs":["get","list","watch","create","update","patch","delete"]},{"apiGroups":["coordination.k8s.io"],"resources":["leases"],"verbs":["get","list","watch","create","update","patch","delete"]},{"apiGroups":[""],"resources":["events"],"verbs":["create","patch"]}]},"livenessProbe":{"httpGet":{"path":"/healthz","port":"health"},"initialDelaySeconds":15,"periodSeconds":20},"nodeSelector":{},"podAnnotations":{},"podLabels":{},"podSecurityContext":{"runAsNonRoot":true},"ports":[{"containerPort":8080,"name":"metrics","protocol":"TCP"},{"containerPort":8081,"name":"health","protocol":"TCP"}],"proxyHost":"0.0.0.0","rbac":{"allowedNamespaces":[],"scope":"cluster"},"readinessProbe":{"httpGet":{"path":"/readyz","port":"health"},"initialDelaySeconds":5,"periodSeconds":10},"replicaCount":1,"resources":{"limits":{"cpu":"500m","memory":"128Mi"},"requests":{"cpu":"10m","memory":"64Mi"}},"serviceAccount":{"annotations":{},"automountServiceAccountToken":true,"create":true,"labels":{},"name":"toolhive-operator"},"tolerations":[],"toolhiveRunnerImage":"ghcr.io/stacklok/toolhive/proxyrunner:v0.7.2","vmcpImage":"ghcr.io/stacklok/toolhive/vmcp:v0.7.2","volumeMounts":[],"volumes":[]}` | All values for the operator deployment and associated resources |