chore: clean-up#13470
Merged
Merged
Conversation
Add `division` and `quotient` to the keywords array so all three `?xdy` siblings (`sxdy`, `dxdy`, `gxdy`) advertise the same operation-related terms. Ref: bb60d76 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018vjPsqFDNCPHYDBR7WZbWK
The Notes bullet claimed that an out-of-range value or invalid radix yields `0` in both output words, but the implementation throws a `RangeError` in both cases (see `lib/assign.js` and `test/test.assign.js`). Ref: edd8fe3 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018vjPsqFDNCPHYDBR7WZbWK
develop on 2026-07-14develop on 2026-07-14
Contributor
Coverage ReportNo coverage information available. |
kgryte
reviewed
Jul 14, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
approved these changes
Jul 14, 2026
develop on 2026-07-14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
developbetween 2026-07-13 09:33 UTC and 2026-07-14 07:31 UTC (SHA rangeccb03e301..6208ff550, 40 first-parent commits).Fixes
blas/ext/base/dxdy—chore: align keywords with sibling packages. @bb60d76f1: keywords inlib/node_modules/@stdlib/blas/ext/base/dxdy/package.jsonare out of sync with thesxdysibling — missing"division"and"quotient". Added both after"divide"so all three?xdyvariants carry the same keyword set.number/uint64/base/string2words—docs: correct error semantics in notes. The README## Notesinlib/node_modules/@stdlib/number/uint64/base/string2words/README.md(introduced inedd8fe361) claimed an out-of-range value or invalid radix yields0for both words;lib/assign.jsactually throws aRangeErrorin both cases, per the@throwsdoc andtest/test.assign.js. Rewrote the Notes bullet to state theRangeErrorbehavior so the README matches the implementation.Related Issues
No related issues.
Questions
No.
Other
Validation. The 40-commit window was audited along two axes:
docs/style-guides/javascript/README.mdanddocs/style-guides/c/README.md, with each new package diff-compared against an established sibling of similar shape (e.g.blas/base/ndarray/cgemvfor the new ndarray Level-2 kernels,blas/ext/base/dfill/sfill/gfillfor the?xdytrio, andsgd-regressionsiblings for the new SGD enum resolvers).sxdy/dxdybindings, and doc/test consistency for thefftpack/cosqi/sinqifixes). No bugs surfaced.Deliberately excluded. Subjective preferences, style deviations that also exist in the sibling reference packages (pre-existing, not introduced by the window), the
dspr/sspr/dsyr2/ssyr2enum-refactor cluster's intentional per-package repetition (established stdlib pattern per commit bodies), and cosmetic whitespace differences not codified in the style guide.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by an automated Claude Code routine: the 24-hour
developcommit window was scanned by four parallel review agents (two style-compliance passes and two bug-focused passes), each finding was independently re-verified against the worktree before being applied, and the two fixes above are the only high-signal issues that survived filtering. A human maintainer will audit before marking ready for review.@stdlib-js/reviewers
Generated by Claude Code