Skip to content

chore: clean-up#13470

Merged
kgryte merged 3 commits into
developfrom
philipp/fix-commit-review-2026-07-14
Jul 14, 2026
Merged

chore: clean-up#13470
kgryte merged 3 commits into
developfrom
philipp/fix-commit-review-2026-07-14

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • Applies follow-up fixes for two commits merged to develop between 2026-07-13 09:33 UTC and 2026-07-14 07:31 UTC (SHA range ccb03e301..6208ff550, 40 first-parent commits).

Fixes

  • blas/ext/base/dxdychore: align keywords with sibling packages. @bb60d76f1: keywords in lib/node_modules/@stdlib/blas/ext/base/dxdy/package.json are out of sync with the sxdy sibling — missing "division" and "quotient". Added both after "divide" so all three ?xdy variants carry the same keyword set.
  • number/uint64/base/string2wordsdocs: correct error semantics in notes. The README ## Notes in lib/node_modules/@stdlib/number/uint64/base/string2words/README.md (introduced in edd8fe361) claimed an out-of-range value or invalid radix yields 0 for both words; lib/assign.js actually throws a RangeError in both cases, per the @throws doc and test/test.assign.js. Rewrote the Notes bullet to state the RangeError behavior so the README matches the implementation.

Related Issues

Does this pull request have any related issues?

No related issues.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation. The 40-commit window was audited along two axes:

  • Style-guide compliance against docs/style-guides/javascript/README.md and docs/style-guides/c/README.md, with each new package diff-compared against an established sibling of similar shape (e.g. blas/base/ndarray/cgemv for the new ndarray Level-2 kernels, blas/ext/base/dfill/sfill/gfill for the ?xdy trio, and sgd-regression siblings for the new SGD enum resolvers).
  • Objective bug scan across the introduced code (correctness, numeric edge cases at N=0 / negative strides / NaN±0±Inf boundaries, C-source memory/overflow safety in the new sxdy/dxdy bindings, and doc/test consistency for the fftpack/cosqi/sinqi fixes). No bugs surfaced.

Deliberately excluded. Subjective preferences, style deviations that also exist in the sibling reference packages (pre-existing, not introduced by the window), the dspr/sspr/dsyr2/ssyr2 enum-refactor cluster's intentional per-package repetition (established stdlib pattern per commit bodies), and cosmetic whitespace differences not codified in the style guide.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by an automated Claude Code routine: the 24-hour develop commit window was scanned by four parallel review agents (two style-compliance passes and two bug-focused passes), each finding was independently re-verified against the worktree before being applied, and the two fixes above are the only high-signal issues that survived filtering. A human maintainer will audit before marking ready for review.


@stdlib-js/reviewers


Generated by Claude Code

claude added 2 commits July 14, 2026 12:28
Add `division` and `quotient` to the keywords array so all three `?xdy`
siblings (`sxdy`, `dxdy`, `gxdy`) advertise the same operation-related
terms.

Ref: bb60d76

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018vjPsqFDNCPHYDBR7WZbWK
The Notes bullet claimed that an out-of-range value or invalid radix
yields `0` in both output words, but the implementation throws a
`RangeError` in both cases (see `lib/assign.js` and `test/test.assign.js`).

Ref: edd8fe3

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018vjPsqFDNCPHYDBR7WZbWK
@Planeshifter Planeshifter changed the title Follow-up fixes for commits merged to develop on 2026-07-14 chore: follow-up fixes for commits merged to develop on 2026-07-14 Jul 14, 2026
@stdlib-bot

stdlib-bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

Comment thread lib/node_modules/@stdlib/number/uint64/base/string2words/README.md Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte marked this pull request as ready for review July 14, 2026 22:13
@kgryte kgryte requested a review from a team July 14, 2026 22:13
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 14, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jul 14, 2026
@kgryte kgryte changed the title chore: follow-up fixes for commits merged to develop on 2026-07-14 chore: clean-up Jul 14, 2026
@kgryte kgryte merged commit f175a72 into develop Jul 14, 2026
33 of 34 checks passed
@kgryte kgryte deleted the philipp/fix-commit-review-2026-07-14 branch July 14, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants