Fix CustomData Search Dict Urlencoding

[rdegges]

If we use customdata search currently, using dict sytax, this can result in urlencoding errors (I believe). We should debug this.

account = application.accounts.search({'customData': 'favoriteColor=true'})

The issue here (I believe) is that this generates a query string that looks like:

/v1/application/xxx/accounts?q=customData.favoriteColor=true

Which is an invalid URL.

I think the solution here is to debug the urlencoding functionality when this happens.

[dinkom]

I've tried testing this and it turns out the value of the query is urlencoded, but the problem I got was not related to the url:

acc = directory.accounts.search({'customData': 'foo=bar'})[0]
# results in: /v1/directories/xxx/accounts?customData=foo%3Dbar
# returns: Account customData is not a supported query value (400)

acc = directory.accounts.search({'customData.foo': 'bar'})[0]
# results in: /v1/directories/xxx/accounts?customData.foo=bar
# returns: Account (200)

acc = app.accounts.search({'customData': 'foo=bar'})[0]
# results in: /v1/applications/xxx/accounts?customData=foo%3Dbar
# returns: Account customData is not a supported query value (400)

acc = app.accounts.search({'customData.foo': 'bar'})[0]
# results in: /v1/applications/xxx/accounts?customData.foo=bar
# returns: Account customData.foo is not a supported query value (400)

As you can see, the only time I get a propers response is by search a directory with the syntax 'customData.key': 'value' (it was the same with 'custom_data.key': 'value').

Is it possible that the REST api does not allow querying customData unless it's on a directory/accounts, not app/accounts? Also, the syntax you used above is a bit different then the syntax I've seen so far in the SDK for browsing customData - are you sure it's supposed to be working?

[rdegges]

Thanks for this! Let me check with the core team and see what's up :o