Spun off from review on #601 (pre-existing; not introduced there).
The Rust installer's model_archive_kind (apps/skit/src/marketplace_installer.rs) matches suffixes with eq_ignore_ascii_case, while the Python uploader's archive_mode (scripts/marketplace/upload_models_to_hf.py) uses case-sensitive str.endswith. So model.TAR.GZ is recognized by the installer but not by the uploader — the same class of install-vs-upload divergence #572 addressed, just milder (filenames are conventionally lowercase).
Suggested fix: lowercase before matching in Python (e.g. file_path.lower().endswith(suffix), suffixes in archive_suffixes.json are already lowercase) and extend the parity coverage to exercise mixed-case names. Left out of #601 to keep that PR focused on the zstd gap.
Spun off from review on #601 (pre-existing; not introduced there).
The Rust installer's
model_archive_kind(apps/skit/src/marketplace_installer.rs) matches suffixes witheq_ignore_ascii_case, while the Python uploader'sarchive_mode(scripts/marketplace/upload_models_to_hf.py) uses case-sensitivestr.endswith. Somodel.TAR.GZis recognized by the installer but not by the uploader — the same class of install-vs-upload divergence #572 addressed, just milder (filenames are conventionally lowercase).Suggested fix: lowercase before matching in Python (e.g.
file_path.lower().endswith(suffix), suffixes inarchive_suffixes.jsonare already lowercase) and extend the parity coverage to exercise mixed-case names. Left out of #601 to keep that PR focused on the zstd gap.