PR changes

Author: glenwperry

src/examples/create_pattern_for_sync_route_editor.test.js

@@ -20,9 +20,9 @@ describe('When getting a pattern for use in the Sync route editor', () => {
     fetchMock.get('/1/SYNC/patterns/editor/1', {
       status: 200,
     });
-
+    const patternId = 1;
     const getPatternForSyncRouteEditorPromise = api.customer('SYNC').patterns()
-        .getPatternForSyncRouteEditor(1)
+        .getPatternForSyncRouteEditor(patternId)
         .then(getPatternResponse => {
           getPatternResponse.should.be.an('object');
         });

src/resources/Detour.js

@@ -29,35 +29,22 @@ class Detour extends Resource {
   async getHistoricalDetours(from, until, includeDeactivated, expandDetails, count) {
     const { code, client } = this;
 
-    let endpoint = `/2/${code}/serviceadjustments/detours/historical`;
-    const params = [];
+    const endpoint = `/2/${code}/serviceadjustments/detours/historical`;
+    const params = new URLSearchParams();
 
-    if (from instanceof Date) {
-      params.push(`from=${encodeURIComponent(from.toISOString())}`);
-    }
-    if (until instanceof Date) {
-      params.push(`until=${encodeURIComponent(until.toISOString())}`);
-    }
-    if (includeDeactivated) {
-      params.push('includeDeactivated=true');
-    }
-    if (expandDetails) {
-      params.push('expandDetails=true');
-    }
-    if (typeof count === 'number' && count > 0) {
-      params.push(`count=${count}`);
-    }
+    if (from instanceof Date) params.set("from", from.toISOString());
+    if (until instanceof Date) params.set("until", until.toISOString());
+    if (includeDeactivated) params.set("includeDeactivated", "true");
+    if (expandDetails) params.set("expandDetails", "true");
+    if (typeof count === "number" && count > 0) params.set("count", count);
 
-    if (params.length > 0) {
-      endpoint += `?${params.join('&')}`;
-    }
-
-    const response = await client.get(endpoint);
+    const url = params.toString() ? `${endpoint}?${params.toString()}` : endpoint;
+    const response = await client.get(url);
     const detours = await response.json();
+
     return detours.map(detour => new Detour(client, detour));
   }
 
-
   /**
    * Makes a href for a given customer code and detour id
    * @param {string} customerCode Customer code