diff --git a/.agents/commands/pr.md b/.agents/commands/pr.md index ccdde89d3..05f1cc9bf 100644 --- a/.agents/commands/pr.md +++ b/.agents/commands/pr.md @@ -111,6 +111,17 @@ When the user provides custom instructions after `--`: - Preserve exact manual testing steps provided by the user (don't summarize or omit details) - If custom instructions include automated checks or coverage notes, place them under `#### Automated Checks` +**Design:** +- Include a `### Design` section when the PR template contains a `### Design` heading. +- For user-visible UI changes with an existing design, link the relevant Figma frames, starting with the latest `Bitkit - Handoff vNN` page in https://www.figma.com/design/ltqvnKiejWj0JQiqtDf2JJ/. +- For user-visible UI changes with no available design, including new features, write `N/A — no design available.` +- For changes without user-visible UI changes, write `N/A — no UI changes.` +- If the relevant Figma frame is missing or uncertain, state the uncertainty. +- Never invent a Figma link or require a new design. +- Reviewers may make at most one advisory request per PR when an existing-design UI PR omits its Figma link. +- `N/A — no UI changes.` needs no review request; `N/A — no design available.` may receive the single advisory clarification. +- Missing Figma links never block approval, CI, PR creation, or review readiness. + **QA Notes / Validation:** - QA Notes separate actionable human QA instructions from automated verification coverage. - Always use this structure: diff --git a/.agents/commands/release.md b/.agents/commands/release.md index 3d7c9b2b7..f154965e7 100644 --- a/.agents/commands/release.md +++ b/.agents/commands/release.md @@ -126,6 +126,10 @@ Bump version to {newVersionName} (build {newBuildNumber}) for release. - `CURRENT_PROJECT_VERSION`: {oldBuildNumber} → {newBuildNumber} - `MARKETING_VERSION`: {oldVersionName} → {newVersionName} +### Design + +N/A — no UI changes. + ### Screenshot / Video N/A diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index ac5c0fee6..526002e03 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -8,6 +8,16 @@ Please include a summary of changes and which issues are fixed. Please also incl Add any links to GitHub issues or Asana tasks that are relevant to this pull request. +### Design + + + ### Screenshot / Video Insert relevant screenshot / recording diff --git a/AGENTS.md b/AGENTS.md index 0e77a0169..5398d5923 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -337,6 +337,17 @@ New feature (`TransferTrackingManager`) tracks pending transfers to handle edge Ensure accessibility modifiers and labels are added to custom components. +### Figma Designs + +- UI PRs with an existing design must link the relevant Figma frames under `### Design`, starting with the latest `Bitkit - Handoff vNN` page in https://www.figma.com/design/ltqvnKiejWj0JQiqtDf2JJ/. +- UI PRs with no available design, including new features, must use `N/A — no design available.` under `### Design`. +- PRs without user-visible UI changes must use `N/A — no UI changes.` under `### Design`. +- Missing or uncertain Figma frames must be reported honestly. +- Never invent a Figma link or require a new design. +- Reviewers may make at most one advisory request per PR when an existing-design UI PR omits its Figma link. +- `N/A — no UI changes.` needs no review request; `N/A — no design available.` may receive the single advisory clarification. +- Missing Figma links never block approval, CI, PR creation, or review readiness. + ## Code Style & Conventions - **SwiftFormat** configuration in `.swiftformat`